Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frameit] Change framefile.json load path to support Screengrab and Supply #16306

Merged

Conversation

wellavelino
Copy link
Contributor

Issue #16289
When using screengrab and frameit, frameit doesnt load properly
the config file because it matches the current iOS setup,
to be able to load the android properly we need to fully extend the
path.

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

This PR fixes this issue: #16289
I noticed that frameit expects the Framefile.json to be in a specific folder location, but when using it with screengrab and supply it doesn't support the folder structure, I saw the in the PR ea4d8a2
the method create_config was created but isn't considering the actual support to supply/screengrab, the screenshots have added the frame but it doesn't add the background.

Description

I've just extended the path to be 4 levels deep.
Since I couldn't see much value in add a test for this specific method I tested loading from different paths, but if you guys think that might be cool I can add it.

Testing Steps

Just created a new test in the config_parser_spec to simulate it to be and tested in a local project.
I can add the test if it's ok.

Issue fastlane#16289
When using screengrab and frameit, frameit doesnt load properly
the config file because it matches the current iOS setup,
to be able to load the android properly we need to fully extend the
path.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@wellavelino
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@wellavelino wellavelino changed the title Change framefile.json load path to support Screengrab and Supply [frameit]Change framefile.json load path to support Screengrab and Supply Apr 17, 2020
@janpio janpio changed the title [frameit]Change framefile.json load path to support Screengrab and Supply [frameit] Change framefile.json load path to support Screengrab and Supply Apr 19, 2020
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thought on keeping the removed line 😇 And if there is an existing spot to add another test for this that would be great! If not don’t worry about it 🙃

frameit/lib/frameit/runner.rb Show resolved Hide resolved
@wellavelino
Copy link
Contributor Author

hey @joshdholtz can you have a look when you have some time?
Cheers

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Appreciate the contribution ❤️

@joshdholtz joshdholtz merged commit a4b6c29 into fastlane:master Apr 27, 2020
@fastlane-bot
Copy link

Hey @wellavelino 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@wellavelino
Copy link
Contributor Author

@joshdholtz no worries, looking forward to open my second PR screengrab related

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.147.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants