-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frameit] Change framefile.json load path to support Screengrab and Supply #16306
[frameit] Change framefile.json load path to support Screengrab and Supply #16306
Conversation
Issue fastlane#16289 When using screengrab and frameit, frameit doesnt load properly the config file because it matches the current iOS setup, to be able to load the android properly we need to fully extend the path.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thought on keeping the removed line 😇 And if there is an existing spot to add another test for this that would be great! If not don’t worry about it 🙃
hey @joshdholtz can you have a look when you have some time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! Appreciate the contribution ❤️
Hey @wellavelino 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
@joshdholtz no worries, looking forward to open my second PR screengrab related |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.147.0 🚀
Issue #16289
When using screengrab and frameit, frameit doesnt load properly
the config file because it matches the current iOS setup,
to be able to load the android properly we need to fully extend the
path.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
This PR fixes this issue: #16289
I noticed that frameit expects the Framefile.json to be in a specific folder location, but when using it with screengrab and supply it doesn't support the folder structure, I saw the in the PR
ea4d8a2
the method
create_config
was created but isn't considering the actual support to supply/screengrab, the screenshots have added the frame but it doesn't add the background.Description
I've just extended the path to be 4 levels deep.
Since I couldn't see much value in add a test for this specific method I tested loading from different paths, but if you guys think that might be cool I can add it.
Testing Steps
Just created a new test in the config_parser_spec to simulate it to be and tested in a local project.
I can add the test if it's ok.