Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pod_lib_lint] add "analyze" option #16190

Merged
merged 4 commits into from Mar 19, 2020
Merged

[pod_lib_lint] add "analyze" option #16190

merged 4 commits into from Mar 19, 2020

Conversation

macblazer
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Closes #16187

Description

Added "analyze" option to the pod_lib_lint action. This maps to the "--analyze" option that is available in CocoaPods since v1.6.1.

Testing Steps

I tested my changes in a local clone of a pod repo with a lane that looked liked:

desc "Runs the unit tests for a CocoaPod"
lane :test_pod do
  pod_lib_lint(sources: ["https://github.com/CocoaPods/Specs"],
  	analyze: true,
        verbose: true)
end

Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful

@janpio janpio merged commit 3168f62 into fastlane:master Mar 19, 2020
@macblazer macblazer deleted the pod_lib_lint-add-analyze-option branch March 19, 2020 21:15
@fastlane-bot
Copy link

Hey @macblazer 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.144.0 🚀

@fastlane fastlane locked and limited conversation to collaborators May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pod_lib_lint] Add "analyze" option
4 participants