[deliver] Provide 'env_name' to each config option that didn't previously have one* #16179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
I've recently been having a good cleanup of our Fastlane scripts and configurations to start relying more on .env files as our main source of configuration. We prefer this approach since we utilise many custom actions that don't offer support for other config files (such as Deliverfile and so on) and as a result, all of our default action configuration exists in one place (and is overloaded for different environments).
As a result, our Fastfiles become very clear and easy to follow since we're passing very minimal arguments into each action in most cases. The downside is that not all actions provide the
env_name
for all of theirConfigItem
definitions.Description
In this change, I've updated Deliver's options to update any
ConfigItem
instances that are currently missingenv_name
where the type can be passed via a string (in this case, it's any types other thanHash
).I've used the naming convention
DELIVER_{key}
and in some cases, where the value is documented as a file path, and the key doesn't contain the suffix_PATH
, I've appended it also (to match:ipa
and:pkg
).Please let me know if there was a specific reason as to why these shouldn't be provided? Hopefully this is a relatively small and harmless change 🙏
Testing Steps
Run deliver using the new environment variables to pass in the parameters.