Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deliver] Provide 'env_name' to each config option that didn't previously have one* #16179

Merged
merged 1 commit into from Mar 18, 2020

Conversation

liamnichols
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
    • These get auto generated, right?

Motivation and Context

I've recently been having a good cleanup of our Fastlane scripts and configurations to start relying more on .env files as our main source of configuration. We prefer this approach since we utilise many custom actions that don't offer support for other config files (such as Deliverfile and so on) and as a result, all of our default action configuration exists in one place (and is overloaded for different environments).

As a result, our Fastfiles become very clear and easy to follow since we're passing very minimal arguments into each action in most cases. The downside is that not all actions provide the env_name for all of their ConfigItem definitions.

Description

In this change, I've updated Deliver's options to update any ConfigItem instances that are currently missing env_name where the type can be passed via a string (in this case, it's any types other than Hash).

I've used the naming convention DELIVER_{key} and in some cases, where the value is documented as a file path, and the key doesn't contain the suffix _PATH, I've appended it also (to match :ipa and :pkg).

Please let me know if there was a specific reason as to why these shouldn't be provided? Hopefully this is a relatively small and harmless change 🙏

Testing Steps

Run deliver using the new environment variables to pass in the parameters.

@janpio janpio changed the title [Deliver] Provide 'env_name' to each config option that didn't previously have one* [deliver] Provide 'env_name' to each config option that didn't previously have one* Mar 17, 2020
@janpio janpio requested a review from joshdholtz March 17, 2020 10:37
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I noticed a few days ago that these were missing! Thanks for adding them 😊 Appreciate the contribution ❤️

@joshdholtz joshdholtz merged commit d9ec99b into fastlane:master Mar 18, 2020
@liamnichols liamnichols deleted the ln/deliver-env-names branch March 18, 2020 16:10
@fastlane-bot
Copy link

Hey @liamnichols 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.144.0 🚀

@fastlane fastlane locked and limited conversation to collaborators May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants