Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clean_build_artifacts] Remove references to downloaded files after they are deleted #16178

Merged
merged 1 commit into from Mar 18, 2020
Merged

Conversation

guykogus
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

When attempting to download dSYMs for multiple apps it should be possible to clear the references for the dSYMs that have been deleted.

See #16177

Description

Calling clean_build_artifacts now removes the references to the deleted files.

Testing Steps

@janpio janpio changed the title Remove references to downloaded files after they are deleted [clean_build_artifacts] Remove references to downloaded files after they are deleted Mar 17, 2020
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh, this is smart! Thanks for catching this 😊 Appreciate the contribution ❤️

@joshdholtz joshdholtz merged commit 96accba into fastlane:master Mar 18, 2020
@guykogus guykogus deleted the clear-context branch March 18, 2020 16:11
@fastlane-bot
Copy link

Hey @guykogus 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.144.0 🚀

@fastlane fastlane locked and limited conversation to collaborators May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants