New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[supply] Fixing empty track use case #16161
Conversation
The Google Play API returns a different error message body now, and the value of "e.to_s" is now something like this: "notFound: Track not found: alpha". I don't know if the "trackEmpty" case still applies, but I left it there in case. !!! Please verify and test this before merging !!! I have not tested this myself and this is just how I assume it should be fixed, maybe it's something completely different. This is meant to fix a bug that is now happening: the "google_play_track_version_codes" lane will error out if querying for the version codes list of an empty track.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
After a quick search, I noticed someone has reported this as an issue: |
@androidseb Hey! Can you accept the CLA so the we can merge this? 😊 |
Hey, yes, sorry, I had been procrastinating on that one, I'll do that today. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@joshdholtz we should be good to go now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Appreciate the contribution ❤️
Hey @androidseb 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
I need this release to push an app update to our beta channel. |
@etwilliams This will be getting released today! |
Fantastic! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.144.0 🚀
The Google Play API returns a different error message body now, and the value of "e.to_s" is now something like this: "notFound: Track not found: alpha". I don't know if the "trackEmpty" case still applies, but I left it there in case.
!!! Please verify and test this before merging !!!
I have not tested this myself and this is just how I assume it should be fixed, maybe it's something completely different.
This is meant to fix a bug that is now happening: the "google_play_track_version_codes" lane will error out if querying for the version codes list of an empty track.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Fixes #16159
Description
Testing Steps