Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[supply] Fixing empty track use case #16161

Merged
merged 1 commit into from Mar 18, 2020
Merged

Conversation

androidseb
Copy link
Contributor

@androidseb androidseb commented Mar 11, 2020

The Google Play API returns a different error message body now, and the value of "e.to_s" is now something like this: "notFound: Track not found: alpha". I don't know if the "trackEmpty" case still applies, but I left it there in case.
!!! Please verify and test this before merging !!!
I have not tested this myself and this is just how I assume it should be fixed, maybe it's something completely different.

This is meant to fix a bug that is now happening: the "google_play_track_version_codes" lane will error out if querying for the version codes list of an empty track.

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Fixes #16159

Description

Testing Steps

The Google Play API returns a different error message body now, and the value of "e.to_s" is now something like this: "notFound: Track not found: alpha". I don't know if the "trackEmpty" case still applies, but I left it there in case.
!!! Please verify and test this before merging !!!
I have not tested this myself and this is just how I assume it should be fixed, maybe it's something completely different.

This is meant to fix a bug that is now happening: the "google_play_track_version_codes" lane will error out if querying for the version codes list of an empty track.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@androidseb
Copy link
Contributor Author

After a quick search, I noticed someone has reported this as an issue:
#16159

@janpio janpio changed the title Fixing empty track use case [supply]Fixing empty track use case Mar 12, 2020
@janpio janpio changed the title [supply]Fixing empty track use case [supply] Fixing empty track use case Mar 12, 2020
@janpio janpio added tool: supply upload_to_playstore and removed cla: no labels Mar 12, 2020
@janpio janpio requested a review from joshdholtz March 12, 2020 19:30
@joshdholtz
Copy link
Member

@androidseb Hey! Can you accept the CLA so the we can merge this? 😊

@androidseb
Copy link
Contributor Author

Hey, yes, sorry, I had been procrastinating on that one, I'll do that today.

@androidseb
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@androidseb
Copy link
Contributor Author

@joshdholtz we should be good to go now

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Appreciate the contribution ❤️

@joshdholtz joshdholtz merged commit c762d7f into fastlane:master Mar 18, 2020
@fastlane-bot
Copy link

Hey @androidseb 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@etwilliams
Copy link

I need this release to push an app update to our beta channel.

@joshdholtz
Copy link
Member

@etwilliams This will be getting released today!

@etwilliams
Copy link

Fantastic!

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.144.0 🚀

@fastlane fastlane locked and limited conversation to collaborators May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_play_track_version_codes notFound: Track not found
6 participants