Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation message to Crashlytic's Beta action #16157

Merged
merged 2 commits into from Mar 18, 2020

Conversation

alexsinger
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Crashlytics Beta is deprecated and has been replaced with Firebase App Distribution. Fabric, along with Crashlytics Beta, are being shut down on March 31, 2020

Description

Update crashlytics action to label it as deprecated and call out Firebase App Distribution as its replacement.


def self.deprecated_notes
[
"Crashlytics Beta has been deprecated and replaced with Firebase App Distribution.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a hard date for this deprecation? I usually like to include that to show urgency 😊

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's fast approaching (3/31/2020). I can include it for clarity, but urgency should already be there from other Fabric touch points :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@alexsinger
Copy link
Contributor Author

@joshdholtz how's this looking now?

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making that update! I will get a new version out today 😊 Appreciate the contribution ❤️

@joshdholtz joshdholtz merged commit 72dafeb into fastlane:master Mar 18, 2020
@fastlane-bot
Copy link

Hey @alexsinger 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.144.0 🚀

@fastlane fastlane locked and limited conversation to collaborators May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants