New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation message to Crashlytic's Beta action #16157
Add deprecation message to Crashlytic's Beta action #16157
Conversation
|
||
def self.deprecated_notes | ||
[ | ||
"Crashlytics Beta has been deprecated and replaced with Firebase App Distribution.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a hard date for this deprecation? I usually like to include that to show urgency 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's fast approaching (3/31/2020). I can include it for clarity, but urgency should already be there from other Fabric touch points :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
@joshdholtz how's this looking now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making that update! I will get a new version out today 😊 Appreciate the contribution ❤️
Hey @alexsinger 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.144.0 🚀
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Crashlytics Beta is deprecated and has been replaced with Firebase App Distribution. Fabric, along with Crashlytics Beta, are being shut down on March 31, 2020
Description
Update
crashlytics
action to label it as deprecated and call out Firebase App Distribution as its replacement.