[fastlane] migrate from AWS-SDK v2 to AWS-SDK v3

[Kaspik]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

Fixes #16130.
Repairs #15200.

Description

Currently Fastlane uses AWS-SDK v2 and is deprecated.
We could easily migrate to v3 just by changing the version number (via https://docs.aws.amazon.com/sdk-for-ruby/v3/api/ - Upgrade from version 2 - If you depend on aws-sdk or aws-sdk-resources, you don't need to change anything. Meanwhile we recommend you to revisit following options to explore modularization benefits.), but because we need only S3 part of the library, and AWS-SDK V3 introduced modularization, it makes sense not to include 200 sub-dependencies, but point only to the required one.

Testing Steps

Everything mentioned in Checklist.

Other notes

Introducing AWS-SDK in latest Fastlane causes a lot of issues so I think there should be a minor hotfix release.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[Kaspik]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[Kaspik]

I'm pretty sure tests are green, but not sure why that one failed. Locally everything works.

[liamnichols]

Ahh amazing, I've been running around in circles trying to find out why bundler has started getting stuck resolving dependencies.

We have a private plugin that is using aws-sdk-s3 as well and with a simple Gemfile like the following:

source 'https://rubygems.org'

gem 'fastlane'
gem 'fastlane-plugin-my_private_plugin' # .gemspec contains `spec.add_dependency 'aws-sdk-s3'`

Running bundle install will now loop indefinitely due to some madness within the aws-sdk gemspec that I haven't quite figured out just yet.

I tried using your fork and everything now works again 🙏

Edit: I just read the linked ticket, wish I found that earlier 😅

[Kaspik]

My fork will be removed once that happens, until then feel free to use it. :)

[janpio]

LGTM

[Kaspik]

Let me know @joshdholtz what you think about this, as I mentioned - I think this could be a reason for hotfix (minor 2.143.1) release.

[liamnichols]

BTW the workaround I suggested in #16130 isn't really ideal in many scenarios since the bloat from the non-modularised version of the v3 SDK is quiet significant... It would be reallllllyyyy awesome if this simple change could make it into the next release 🙏

[joshdholtz]

Thanks for fixing this! I've pulled this down and tested it with my S3 integration and things seem good 😊 Appreciate the contribution ❤️

[liamnichols]

Thanks @joshdholtz and @Kaspik for this! 🙏

[fastlane-bot]

Hey @Kaspik 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

[Kaspik]

I think it should go sooner than later, and it has been 2 weeks since last release. :)

[joshdholtz]

@Kaspik Will be making a new release today and keeping up better in the future! My apologies on not getting a release out. Been balancing a lot of stuff lately and I've let things slip 😔

[Kaspik]

Glad to hear that @joshdholtz , thanks! :)

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.144.0 🚀