New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[swiftlint] add support for the --no-cache flag on autocorrect and lint #16132
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@@ -19,6 +19,7 @@ def self.run(params) | |||
command << " --reporter #{params[:reporter]}" if params[:reporter] | |||
command << supported_option_switch(params, :quiet, "0.9.0", true) | |||
command << supported_option_switch(params, :format, "0.11.0", true) if params[:mode] == :autocorrect | |||
command << " --no-cache" if params[:no_cache] and (params[:mode] == :autocorrect or params[:mode] == :lint) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix these two rubocop problems:
[12:53:22]: ▸ fastlane/lib/fastlane/actions/swiftlint.rb:22:55: C: Style/AndOr: Use && instead of and.
[12:53:22]: ▸ command << " --no-cache" if params[:no_cache] and (params[:mode] == :autocorrect or params[:mode] == :lint)
[12:53:22]: ▸ ^^^
[12:53:22]: ▸ fastlane/lib/fastlane/actions/swiftlint.rb:22:90: C: Style/AndOr: Use || instead of or.
[12:53:22]: ▸ command << " --no-cache" if params[:no_cache] and (params[:mode] == :autocorrect or params[:mode] == :lint)
[12:53:22]: ▸ ^^
command << " --no-cache" if params[:no_cache] and (params[:mode] == :autocorrect or params[:mode] == :lint) | |
command << " --no-cache" if params[:no_cache] && (params[:mode] == :autocorrect || params[:mode] == :lint) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback addressed @janpio
Hey @kronenthaler 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.144.0 🚀
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
This PR allows to pass the --no-cache flag to the autocorrect and lint commands. This helps to solve some weird behavior when formatting the code and the cache becomes stale causing lost of chunks of code.
Description
Added an option (like --format) to allow passing --no-cache flag.
Testing Steps
Updated the unit test to append the --no-cache flag if present to lint and autocorrect commands.