Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swiftlint] add support for the --no-cache flag on autocorrect and lint #16132

Merged
merged 6 commits into from Mar 7, 2020

Conversation

kronenthaler
Copy link
Contributor

@kronenthaler kronenthaler commented Mar 6, 2020

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

This PR allows to pass the --no-cache flag to the autocorrect and lint commands. This helps to solve some weird behavior when formatting the code and the cache becomes stale causing lost of chunks of code.

Description

Added an option (like --format) to allow passing --no-cache flag.

Testing Steps

Updated the unit test to append the --no-cache flag if present to lint and autocorrect commands.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@kronenthaler
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Mar 6, 2020
@janpio janpio changed the title add support for the --no-cache flag on autocorrect and lint [swiftlint] add support for the --no-cache flag on autocorrect and lint Mar 6, 2020
@@ -19,6 +19,7 @@ def self.run(params)
command << " --reporter #{params[:reporter]}" if params[:reporter]
command << supported_option_switch(params, :quiet, "0.9.0", true)
command << supported_option_switch(params, :format, "0.11.0", true) if params[:mode] == :autocorrect
command << " --no-cache" if params[:no_cache] and (params[:mode] == :autocorrect or params[:mode] == :lint)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix these two rubocop problems:

[12:53:22]: ▸ fastlane/lib/fastlane/actions/swiftlint.rb:22:55: C: Style/AndOr: Use && instead of and.
[12:53:22]: ▸ command << " --no-cache" if params[:no_cache] and (params[:mode] == :autocorrect or params[:mode] == :lint)
[12:53:22]: ▸ ^^^
[12:53:22]: ▸ fastlane/lib/fastlane/actions/swiftlint.rb:22:90: C: Style/AndOr: Use || instead of or.
[12:53:22]: ▸ command << " --no-cache" if params[:no_cache] and (params[:mode] == :autocorrect or params[:mode] == :lint)
[12:53:22]: ▸ ^^
Suggested change
command << " --no-cache" if params[:no_cache] and (params[:mode] == :autocorrect or params[:mode] == :lint)
command << " --no-cache" if params[:no_cache] && (params[:mode] == :autocorrect || params[:mode] == :lint)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback addressed @janpio

@janpio janpio merged commit 5e23f94 into fastlane:master Mar 7, 2020
@fastlane-bot
Copy link

Hey @kronenthaler 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.144.0 🚀

@fastlane fastlane locked and limited conversation to collaborators May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants