[core] Suppress output of PlistBuddy when disabling "KeyboardContinuousPathEnabled" #16123
Conversation
There was a problem hiding this comment.
Would you be able to add some more in the description of this PR on the need for it? Was the output too verbose? I don't remember what happens 🙃
And maybe we could change to using print: false on backticks way to all hide output? Or is it helpful to see the command that is being executed? print: false would hide both the command and the output.
| @@ -223,7 +223,7 @@ def disable_slide_to_type | |||
| plist_buddy_cmd = "-c \"Add :KeyboardContinuousPathEnabled bool false\"" | |||
| plist_path = File.expand_path("~/Library/Developer/CoreSimulator/Devices/#{self.udid}/data/Library/Preferences/com.apple.keyboard.ContinuousPath.plist") | |||
|
|
|||
| Helper.backticks("#{plist_buddy} #{plist_buddy_cmd} #{plist_path}") | |||
| Helper.backticks("#{plist_buddy} #{plist_buddy_cmd} #{plist_path} >/dev/null 2>&1") | |||
There was a problem hiding this comment.
| Helper.backticks("#{plist_buddy} #{plist_buddy_cmd} #{plist_path} >/dev/null 2>&1") | |
| Helper.backticks("#{plist_buddy} #{plist_buddy_cmd} #{plist_path}", print: false) |
This should also work if you want to try this 😊 ☝️
There was a problem hiding this comment.
Unfortunately, after trying this, because the output is an error it is still printed 😠
Updated description with some context. |
joshdholtz
changed the title
joshdholtz
changed the title
|
Hey @robnadin 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.144.0 🚀
fastlane-bot
added
status: released
and removed
status: included-in-next-release
labels
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
Suppress the error output from PlistBuddy when the
KeyboardContinuousPathEnabledkey already exists in the simulator's preferences. On some CI systems this manifests as an error in the build log:Description
Testing Steps