[action] Generate update_code_signing_settings action instead of deprecated automatic_code_signing #15900

att55 · 2020-01-15T04:05:41Z

Checklist

I've run bundle exec rspec from the root directory to see all new and existing tests pass
I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
I've read the Contribution Guidelines
I've updated the documentation if necessary.

Motivation and Context

automatic_code_signing has use_automatic_signing, the key switches Auto to Manual code signing. And the defaulut value is false.

https://docs.fastlane.tools/actions/automatic_code_signing/#automatic_code_signing

Sample code is as below.

automatic_code_signing(
  path: "demo-project/demo/demo.xcodeproj",
  use_automatic_signing: false
)

automatic_code_signing(
  path: "demo-project/demo/demo.xcodeproj",
  use_automatic_signing: true
)

But, I feel the specifications below are strange and confusing users.

Even though the action name is automatic_code_signing, the action allows to switch Auto to Manual code signing.
Even though the action name is automatic_code_signing, Manual code signing is executed by default because the default value of use_automatic_signing is false.

So, I added code_signing as alias of automatic_code_signing to prevent confusing users.

joshdholtz

@att55 👋 This is a very interesting change! I'm a little bit for but also a little bit against this 🤔 I do agree that this action should have a different name but I also don't want to just introduce another action/alias.

Aliases are nice (in this cases since some of the options conflict with the name of the action) but it makes things a little bit harder to maintain and harder to find other actions.

If we are going to do this, I would rather move the logic from AutomaticCodeSigning into one that is better named and add a message saying that we are deprecating AutomaticCodeSigning in the future.

The code_signing name feels a bit too generic to me (I actually thought this PR was for something like sigh or cert at first). I think it would need to be something like update_code_signing_settings

Thoughts?

att55 · 2020-01-28T14:12:04Z

@joshdholtz Thank you so much for your review!

I would rather move the logic from AutomaticCodeSigning into one that is better named and add a message saying that we are deprecating AutomaticCodeSigning in the future.
I think it would need to be something like update_code_signing_settings

I think your plan is very good and update_code_signing_settings is effective to resolve this issue! 😸
I will try to adopt your plan in this PR 👍

att55 · 2020-01-30T10:53:36Z

@joshdholtz I adopted our plan in this PR 👍Please check when you can 🙏

The outline is below.

added the message saying that we are deprecating automatic_code_signing in automatic_code_signing action .
generated update_code_signing_setttings action instead of automatic_code_signing
added a test file for update_code_signing_setttings
added fixtures(xcodeproj) to exec the test of update_code_signing_setttings

joshdholtz

Thanks SO much for making the changes I suggested 🥰 One more small change! If we could use UI.deprecated instead of UI.important that would be 💯

fastlane/lib/fastlane/actions/automatic_code_signing.rb

fastlane/spec/actions_specs/automatic_code_signing_spec.rb

Co-Authored-By: Josh Holtz <josh@rokkincat.com> use ui.deprecated Co-Authored-By: Josh Holtz <josh@rokkincat.com> use ui.deprecated Co-Authored-By: Josh Holtz <josh@rokkincat.com> use ui.deprecated Co-Authored-By: Josh Holtz <josh@rokkincat.com> use ui.deprecated Co-Authored-By: Josh Holtz <josh@rokkincat.com> use ui.deprecated Co-Authored-By: Josh Holtz <josh@rokkincat.com> use ui.deprecated Co-Authored-By: Josh Holtz <josh@rokkincat.com> use ui.deprecated Co-Authored-By: Josh Holtz <josh@rokkincat.com> use ui.deprecated Co-Authored-By: Josh Holtz <josh@rokkincat.com> use ui.deprecated Co-Authored-By: Josh Holtz <josh@rokkincat.com> use ui.deprecated Co-Authored-By: Josh Holtz <josh@rokkincat.com> use ui.deprecated Co-Authored-By: Josh Holtz <josh@rokkincat.com> use ui.deprecated Co-Authored-By: Josh Holtz <josh@rokkincat.com> use ui.deprecated Co-Authored-By: Josh Holtz <josh@rokkincat.com> use ui.deprecated Co-Authored-By: Josh Holtz <josh@rokkincat.com> use ui.deprecated Co-Authored-By: Josh Holtz <josh@rokkincat.com>

googlebot · 2020-02-19T02:33:01Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

att55 · 2020-02-19T02:48:51Z

@googlebot I consent.

att55 · 2020-02-19T02:58:33Z

I thought I've already consented CLAs... 🤔??

att55 · 2020-02-19T03:10:58Z

@joshdholtz Thank you so much for your review and requesting suggested changes to this PR!
I fixed to use UI.deprecated instead of UI.important. 👍
Sorry to bother you, but please check when you can 😄

att55 · 2020-02-19T03:13:43Z

Sorry... I didn't understand how to pass "size-label" and "cla/google"...

att55 · 2020-03-09T03:08:01Z

@joshdholtz Sorry to bother you... please check this PR when you can 🙏

joshdholtz · 2020-03-09T03:08:56Z

Yo yo yo! Will check first thing tomorrow morning ❤️

att55 · 2020-03-11T09:03:07Z

Thank you so much ❤️ It's file, when you really have time 😸

att55 · 2020-03-23T02:22:48Z

@joshdholtz ( When you can... 👀🙏 )

joshdholtz · 2020-03-23T02:23:31Z

Aye aye! Getting back to things first thing tomorrow morning 👌

joshdholtz · 2020-03-23T11:27:49Z

@googlebot I consent.

googlebot · 2020-03-23T11:28:05Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

joshdholtz

Looks good to me! Thanks for making those changes 😊 Appreciate all your contributions ❤️

fastlane-bot · 2020-03-23T19:31:17Z

Hey @att55 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

fastlane-bot

Congratulations! 🎉 This was released as part of fastlane 2.144.0 🚀

add alias for code_signing

9545620

googlebot added the cla: yes label Jan 15, 2020

add alias for automatic_code_signing

1917346

janpio added the tool: action label Jan 26, 2020

joshdholtz requested changes Jan 27, 2020

View reviewed changes

att55 added 3 commits January 29, 2020 01:06

adopt update_code_signing_settings action

abd9792

adopt update_code_signing_settings action

5e6e409

adopt update_code_singing_settings action

e1442f8

fastlane-bot added the status: needs-attention label Jan 29, 2020

att55 added 4 commits January 30, 2020 18:30

take deprecated message into account in test

f66296b

narrow down one category

e98327f

add test of update_code_signing_settings

9b08999

move a position of comma

6ea0032

att55 changed the title ~~[automatic_code_signing] Add code_signing as alias~~ [action] Generate update_code_signing_settings action instead of deprecated automatic_code_signing Feb 5, 2020

janpio requested a review from joshdholtz February 8, 2020 20:36

joshdholtz requested changes Feb 18, 2020

View reviewed changes

googlebot added cla: no and removed cla: yes labels Feb 19, 2020

generate update_code_signing_settings action

1baa755

att55 requested a review from joshdholtz February 19, 2020 03:41

googlebot added cla: yes and removed cla: no labels Mar 23, 2020

joshdholtz approved these changes Mar 23, 2020

View reviewed changes

joshdholtz merged commit 63be9d3 into fastlane:master Mar 23, 2020

fastlane-bot added status: included-in-next-release and removed status: needs-attention labels Mar 23, 2020

joshdholtz mentioned this pull request Mar 24, 2020

Version bump to 2.144.0 #16202

Merged

fastlane-bot reviewed Mar 24, 2020

View reviewed changes

fastlane-bot added status: released and removed status: included-in-next-release labels Mar 24, 2020

fastlane locked and limited conversation to collaborators May 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[action] Generate update_code_signing_settings action instead of deprecated automatic_code_signing #15900

[action] Generate update_code_signing_settings action instead of deprecated automatic_code_signing #15900

att55 commented Jan 15, 2020 •

edited

joshdholtz left a comment

att55 commented Jan 28, 2020 •

edited

att55 commented Jan 30, 2020 •

edited

joshdholtz left a comment

googlebot commented Feb 19, 2020

att55 commented Feb 19, 2020

att55 commented Feb 19, 2020

att55 commented Feb 19, 2020

att55 commented Feb 19, 2020

att55 commented Mar 9, 2020

joshdholtz commented Mar 9, 2020

att55 commented Mar 11, 2020

att55 commented Mar 23, 2020

joshdholtz commented Mar 23, 2020

joshdholtz commented Mar 23, 2020

googlebot commented Mar 23, 2020

joshdholtz left a comment

fastlane-bot commented Mar 23, 2020

fastlane-bot left a comment

[action] Generate update_code_signing_settings action instead of deprecated automatic_code_signing #15900

[action] Generate update_code_signing_settings action instead of deprecated automatic_code_signing #15900

Conversation

att55 commented Jan 15, 2020 • edited

Checklist

Motivation and Context

joshdholtz left a comment

Choose a reason for hiding this comment

att55 commented Jan 28, 2020 • edited

att55 commented Jan 30, 2020 • edited

joshdholtz left a comment

Choose a reason for hiding this comment

googlebot commented Feb 19, 2020

att55 commented Feb 19, 2020

att55 commented Feb 19, 2020

att55 commented Feb 19, 2020

att55 commented Feb 19, 2020

att55 commented Mar 9, 2020

joshdholtz commented Mar 9, 2020

att55 commented Mar 11, 2020

att55 commented Mar 23, 2020

joshdholtz commented Mar 23, 2020

joshdholtz commented Mar 23, 2020

googlebot commented Mar 23, 2020

joshdholtz left a comment

Choose a reason for hiding this comment

fastlane-bot commented Mar 23, 2020

fastlane-bot left a comment

Choose a reason for hiding this comment

att55 commented Jan 15, 2020 •

edited

att55 commented Jan 28, 2020 •

edited

att55 commented Jan 30, 2020 •

edited