From ad1cf01e24191db83d45d1187b0ce3e1c025fe75 Mon Sep 17 00:00:00 2001 From: Pavlos Chrisochoidis Date: Tue, 10 Mar 2020 15:33:05 +0100 Subject: [PATCH] [spaceship] add a check in app_version.setup_screenshots to also check if there is an app_preview already uploaded (#14738) * add a check in setup_screenshots to also check if there is an app_preview alredy uploaded * improve commenting --- spaceship/lib/spaceship/tunes/app_version.rb | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/spaceship/lib/spaceship/tunes/app_version.rb b/spaceship/lib/spaceship/tunes/app_version.rb index 2728ec747c2..d741f06a4b5 100644 --- a/spaceship/lib/spaceship/tunes/app_version.rb +++ b/spaceship/lib/spaceship/tunes/app_version.rb @@ -767,14 +767,19 @@ def container_data_for_language_and_device(data_field, language, device) end def setup_screenshots - # Enable Scaling for all screen sizes that don't have at least one screenshot + # Enable Scaling for all screen sizes that don't have at least one screenshot or at least one trailer (app_preview) # We automatically disable scaling once we upload at least one screenshot language_details = raw_data_details.each do |current_language| language_details = (current_language["displayFamilies"] || {})["value"] (language_details || []).each do |device_language_details| + # Do not enable scaling if a screenshot already exists next if device_language_details["screenshots"].nil? next if device_language_details["screenshots"]["value"].count > 0 + # Do not enable scaling if a trailer already exists + next if device_language_details["trailers"].nil? + next if device_language_details["trailers"]["value"].count > 0 + # The current row includes screenshots for all device types # so we need to enable scaling for both iOS and watchOS apps device_language_details["scaled"]["value"] = true if device_language_details["scaled"]