Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASK, how to exclude minify for spesific routes? #200

Closed
aalfiann opened this issue Jan 9, 2021 · 6 comments · Fixed by #292
Closed

ASK, how to exclude minify for spesific routes? #200

aalfiann opened this issue Jan 9, 2021 · 6 comments · Fixed by #292
Labels
good first issue Good for newcomers semver-minor Issue or PR that should land as semver minor

Comments

@aalfiann
Copy link

aalfiann commented Jan 9, 2021

This is not an issue, I just don't know how to exclude minifier for spesific routes?
Is this possible? how?

Thank you.

@mcollina
Copy link
Member

mcollina commented Jan 9, 2021

I don't think it's possible.

@aalfiann
Copy link
Author

I hope there is a feature for this.

Right now I just modify to spesific routes directly.

Not hard but seems not clean to my routes.

@mcollina
Copy link
Member

Would you like to send a Pull Request to address this issue? Remember to add unit tests.

@mcollina mcollina added good first issue Good for newcomers semver-minor Issue or PR that should land as semver minor labels Jan 10, 2021
@Adibla
Copy link
Contributor

Adibla commented Jan 25, 2022

I could watch this issue if no one else intends to. I have just an advice to ask you: Is there a way to obtain current path from fastify object in order to access it from getTemplate function? Otherwise I could pass it to the function from the caller together with callback and file, What do you think? Thanks

@mcollina
Copy link
Member

req.context.url should have the route definition (console.log req.context to be sure). req.url have the current path.

@Adibla
Copy link
Contributor

Adibla commented Jan 25, 2022

thank you very much, then I will pass the context of the request to the function from the caller. I'll do a MR to confirm soon

@darkgl0w darkgl0w linked a pull request Jan 28, 2022 that will close this issue
4 tasks
@Eomm Eomm closed this as completed in #292 Jan 29, 2022
Eomm pushed a commit that referenced this issue Jan 29, 2022
* feat: start path excluded from html minification

* fix: CI, remove empty array init, doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers semver-minor Issue or PR that should land as semver minor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants