Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions workflows are not triggered when PRs are merged by this action #8

Closed
simoneb opened this issue Feb 17, 2021 · 4 comments 路 Fixed by #9
Closed

GitHub actions workflows are not triggered when PRs are merged by this action #8

simoneb opened this issue Feb 17, 2021 · 4 comments 路 Fixed by #9
Assignees

Comments

@simoneb
Copy link
Collaborator

simoneb commented Feb 17, 2021

馃悰 Bug Report

GitHub actions workflows are not triggered when PRs are merged by this action.

See the long discussion in nearform/fastify-secrets-core#59, which is using this action.

The behavior is by design, to avoid recursive workflow triggers.

Expected behavior

We would like to have workflows triggered by merges done by this action. One of the options is to use a GitHub application to do so. It may be worth researching how to do that.

@simoneb simoneb self-assigned this Mar 1, 2021
@simoneb
Copy link
Collaborator Author

simoneb commented Mar 2, 2021

We intend to address this issue by implementing a new behavior which allows to use GitHub's built-in automerge feature, implemented in #9 .

@simoneb simoneb closed this as completed in #9 Mar 3, 2021
@glensc
Copy link

glensc commented Mar 4, 2021

Could this be documented, how to configure GitHub's built-in auto-merge feature in this project readme?

I only could find "Allow auto-merge" under https://github.com/org/project/settings "Merge button" and even that does not seem to behave like documented:

image

image

@simoneb
Copy link
Collaborator Author

simoneb commented Mar 4, 2021

GitHub's automerge behaves as documented as far as I have seen. Added docs about this here #10

@glensc
Copy link

glensc commented Mar 4, 2021

@simoneb thanks!

maybe the browser plugin I use is somehow interfering:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants