Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(deps): bump node-fetch from 2.6.1 to 3.0.0" #71

Merged
merged 1 commit into from Sep 1, 2021

Conversation

climba03003
Copy link
Member

It is a breaking change #70 (comment)

Reverts #70

@simoneb
Copy link
Collaborator

simoneb commented Sep 1, 2021

Thanks for catching this

@simoneb simoneb merged commit 47482a9 into main Sep 1, 2021
@simoneb simoneb deleted the revert-70-dependabot/npm_and_yarn/node-fetch-3.0.0 branch September 1, 2021 17:43
@jimmywarting
Copy link

the alt solution cold be

const fetch = (...args) => import('node-fetch').then(({default: fetch}) => fetch(...args));

@Eomm Eomm mentioned this pull request Sep 2, 2021
@Eomm Eomm restored the revert-70-dependabot/npm_and_yarn/node-fetch-3.0.0 branch September 2, 2021 09:03
@Eomm Eomm deleted the revert-70-dependabot/npm_and_yarn/node-fetch-3.0.0 branch September 2, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants