Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: subdirectory pull requests from dependabot #61

Merged

Conversation

JamesKyburz
Copy link
Contributor

@JamesKyburz JamesKyburz commented Aug 8, 2021

When dependabot sends pull requests for subdirectories in a monorepo the current regex matching the versions fails.

Fixed the regex and added a test too.

Checklist

@JamesKyburz
Copy link
Contributor Author

It looks like the latest version 2.2.0 hasn't been pushed to the main branch which has 2.1.0 in package*.json files.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JamesKyburz
Copy link
Contributor Author

should I have included dist or is this done when released?

Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

We should make an automatic dist generation on release / commit to master.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dist folder not updated. make sure husky hooks are run please. https://github.com/fastify/github-action-merge-dependabot/blob/main/.husky/pre-commit

@zekth zekth mentioned this pull request Aug 9, 2021
4 tasks
@JamesKyburz
Copy link
Contributor Author

dist folder not updated. make sure husky hooks are run please. https://github.com/fastify/github-action-merge-dependabot/blob/main/.husky/pre-commit

I had a look why the hook wasn't run (I didn't commit with --skip-verify :)) and it's never run, the pre-commit script isn't executable. I will update this pull request with both the dist and chmod +x :)

@simoneb
Copy link
Collaborator

simoneb commented Aug 9, 2021

dist folder not updated. make sure husky hooks are run please. https://github.com/fastify/github-action-merge-dependabot/blob/main/.husky/pre-commit

I had a look why the hook wasn't run (I didn't commit with --skip-verify :)) and it's never run, the pre-commit script isn't executable. I will update this pull request with both the dist and chmod +x :)

Thanks. I've done the last releases of this package and it always ran here, I guess something must have gone awry

@JamesKyburz
Copy link
Contributor Author

updated this pull request to include dist, and made the .husky/pre-commit script executable too.

@simoneb simoneb merged commit 8fb578d into fastify:main Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants