Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace ncc with esbuild #512

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: replace ncc with esbuild #512

wants to merge 2 commits into from

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Oct 11, 2023

Resolves #511

Checklist

@Uzlopak Uzlopak requested a review from simoneb October 11, 2023 10:50
@simoneb
Copy link
Collaborator

simoneb commented Oct 11, 2023

I agree with this change but I wouldn't get it out without testing it first, because we have no guarantees that the output produced by esbuild will actually work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneb simoneb Awaiting requested review from simoneb

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use esbuild instead of ncc
2 participants
@Uzlopak @simoneb