Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option an option to use github's auto-merge feature #301

Closed
2 tasks done
shouichi opened this issue Nov 2, 2022 · 5 comments 路 Fixed by #302
Closed
2 tasks done

Option an option to use github's auto-merge feature #301

shouichi opened this issue Nov 2, 2022 · 5 comments 路 Fixed by #302

Comments

@shouichi
Copy link
Contributor

shouichi commented Nov 2, 2022

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

馃殌 Feature Proposal

Add an option to use github's auto-merge feature.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/automatically-merging-a-pull-request

This feature request may by related to #251.

Motivation

We don't use github actions and CI status checks are required to merge. When dependabot creates a PR, github-action-merge-dependabot immediately tries to merge the PR but fails because the required status checks are not successful. One idea is to use github's auto-merge feature and let github merge PRs instead of github-action-merge-dependabot.

Example

No response

@simoneb
Copy link
Collaborator

simoneb commented Nov 2, 2022

Would you be interested in sending a PR for this?

@shouichi
Copy link
Contributor Author

shouichi commented Nov 2, 2022

Mmm, it won't happen soon to be honest. I'm not familiar with github actions and its api. But I found that to enable auto-merge PRs, we need to use graphql api https://github.com/orgs/community/discussions/24719#discussioncomment-3245222.

@shouichi
Copy link
Contributor Author

shouichi commented Nov 2, 2022

Well, I played with the github api and opened a PR #302. I confirmed that it works but need to add tests. @simoneb Could you help me to finish the PR? Thank you.

@shouichi
Copy link
Contributor Author

shouichi commented Nov 4, 2022

@simoneb Hello, added test to #302. Could you take a look?

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

馃帀 This issue has been resolved in version 3.5.0 馃帀

The release is available on:

Your optic bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants