Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for dependabot's compatibility score #286

Open
2 tasks done
guilhermelimak opened this issue Oct 5, 2022 · 3 comments 路 May be fixed by #287
Open
2 tasks done

Add support for dependabot's compatibility score #286

guilhermelimak opened this issue Oct 5, 2022 · 3 comments 路 May be fixed by #287

Comments

@guilhermelimak
Copy link
Contributor

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

馃殌 Feature Proposal

Description

It would be nice to be able to use dependabot's compatibility score when deciding whether to merge a PR or not.

Notes

There are some reports of this not working as expected and returning unknown insted of the compatibility score for all PRs, but as far as I tested some PRs do have a compatibility score and it seems to be working just fine. Those reports are probably just related to the update not having the 5 candidates needed for the score as mentioned on this comment.

Following are some recent PRs with compatibility score being shown:
nearform/the-fastify-workshop#626
dependabot/fetch-metadata#270

Motivation

No response

Example

No response
@guilhermelimak guilhermelimak linked a pull request Oct 5, 2022 that will close this issue
Open
4 tasks
@simoneb
Copy link
Collaborator

simoneb commented Oct 5, 2022

dependabot/fetch-metadata#270. This PR has a compatibility score badge 95% in the body of the PR, but the output of the fetch-metadata action shows compatibility score 0. https://github.com/nearform/the-fastify-workshop/actions/runs/3180518436/jobs/5184208481#step:2:23

@guilhermelimak
Copy link
Contributor Author

dependabot/fetch-metadata#270. This PR has a compatibility score badge 95% in the body of the PR, but the output of the fetch-metadata action shows compatibility score 0. https://github.com/nearform/the-fastify-workshop/actions/runs/3180518436/jobs/5184208481#step:2:23

That's because compat-lookup wasn't set before.

@simoneb
Copy link
Collaborator

simoneb commented Oct 6, 2022

Understood. We need to think about this a little bit though, in terms of the workflow. I mean, if you set a score value and it's not satisfied, what happens? I guess the PR is not merged, but then what should we do with it? Does dependabot update the score over time? Basically we need to understand a bit the workflow and what users should expect when using the compat score.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support to dependabot's compatibility score guilhermelimak/github-action-merge-dependabot
2 participants
@simoneb @guilhermelimak