New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing tests #180
Merged
simoneb
merged 12 commits into
fastify:main
from
guilhermelimak:feat/improve-test-coverage
Apr 14, 2022
Merged
Add missing tests #180
simoneb
merged 12 commits into
fastify:main
from
guilhermelimak:feat/improve-test-coverage
Apr 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoneb
reviewed
Apr 12, 2022
All options that were declared there are default now.
simoneb
reviewed
Apr 13, 2022
Those changes will be added back in another PR if needed.
simoneb
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing tests to achieve 100% test coverage and enforce it so tests fail if coverage drop from 100%.
Some of the tests will probably never happen in a real world scenario but are required for full coverage nonetheless.
Closes #177.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct