feat: check package changes via package.json diff #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of relying on the Dependabot-generated PR title, the action will now check the package.json's diff and infer which packages were updated and to which versions. This was needed since Dependabot started bumping more than a single package per PR and ommitting their versions from the title.
simoneb
approved these changes
Apr 5, 2022
src/action.js
Outdated
| } | ||
|
|
||
| if (pkgName === 'github-action-merge-dependabot' && isMajorRelease(pr)) { | ||
| const thisModuleChanges = moduleChanges['github-action-merge-dependabot'] |
There was a problem hiding this comment.
let's please extract this hardcoded string into a constant or, even better, grab it from some place where it already exists, e.g. pkg json?
There was a problem hiding this comment.
Done, @simoneb. Thanks for the review
simoneb
approved these changes
Apr 6, 2022
|
@wilkmaia please merge this PR and do a minor release please, using the release gh workflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on the Dependabot-generated PR title, the action will
now check the package.json's diff and infer which packages were updated
and to which versions.
This was needed since Dependabot started bumping more than a single
package per PR and ommitting their versions from the title.
Closes #166
Checklist
npm run testandnpm run lintand the Code of conduct