Skip to content

Update light my request #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 8, 2018
Merged

Update light my request #632

merged 4 commits into from
Jan 8, 2018

Conversation

delvedor
Copy link
Member

@delvedor delvedor commented Jan 7, 2018

As titled.
@evanshortiss we should update the types as well, would you mind to help? :)

cc @fastify/fastify
related: https://github.com/fastify/light-my-request/releases/tag/v2.0.0

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

Sorry, something went wrong.

@delvedor delvedor added breaking change documentation Improvements or additions to documentation labels Jan 7, 2018
@delvedor delvedor requested a review from mcollina January 7, 2018 13:49
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Member

mcollina commented Jan 8, 2018

I have updated the typescript definitions, this can be merged after CI is green.

@delvedor delvedor merged commit e68e477 into master Jan 8, 2018
@delvedor delvedor deleted the update-light-my-request branch January 8, 2018 10:20
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2022
@Eomm Eomm added the semver-major Issue or PR that should land as semver major label Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation semver-major Issue or PR that should land as semver major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants