New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark workflow is broken #5328
Comments
There is also an on-going discussion for cleaning up the (also broken, but for a different reason) plugins-benchmark-pr workflow: fastify/workflows#120, so at the conclusion of that discussion, the same improvements to ensure the workflow runs correctly and is properly labeled cross-fork ought to be implemented here. |
As for the fix, would it be preferable to: |
remove tthe --only=production is imho good |
I've got some potential improvements cooking over in fastify/workflows#121 If there's interest in moving in that direction, I will push forward to get the necessary changes made here which would resolve this issue, otherwise I'll just get a small PR up to fix this specific issue. |
Is this resolved? |
I fixed it with 35a6b99 |
Prerequisites
Issue
The PR benchmark tag workflow (https://github.com/fastify/fastify/blob/main/.github/workflows/benchmark.yml) is currently broken.
Dependencies are installed with
npm install --only=production
-- but the benchmark callsconcurrently
which is listed as a devDependency.See: https://github.com/mweberxyz/fastify/actions/runs/8005536797/job/21865200203
The text was updated successfully, but these errors were encountered: