Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better "hover" debuggability in VSCode #5262

Open
mcollina opened this issue Jan 10, 2024 · 2 comments
Open

Provide better "hover" debuggability in VSCode #5262

mcollina opened this issue Jan 10, 2024 · 2 comments
Labels
typescript TypeScript related

Comments

@mcollina
Copy link
Member

If you "hover" one of our Request or Reply objects, they are overcrowded and hard to understand, and this is an expectation for a good DX in TypeScript:

image

vs alternatives:

image

I'm not sure how we could improve this, because we allow a great degree of flexibility, but this has never been on our radar before.

@mcollina mcollina added the typescript TypeScript related label Jan 10, 2024
@mcollina
Copy link
Member Author

cc @climba03003

@climba03003
Copy link
Member

climba03003 commented Jan 11, 2024

It can be done by grouping the generic and resolved to a single type.
When we passing around it won't be a very long chain of generic.

I have tried once to compact the generic argument but no luck.
The base types is really better to type as unknown to accept any variant.

To be fair, it still provide the information of what is the expected types in the later line.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript TypeScript related
Projects
None yet
Development

No branches or pull requests

3 participants
@mcollina @climba03003 and others