Update modules for v5 #5116
Comments
|
Did you get feedback from openjs regarding tap v18 used as dev dependency? |
|
Majority of the repos are using the shared workflows so CI changes should be easy enough. I'll hop on that. |
|
@jsumners I've just created a issue to work on fastify/rate-limit plugin the link : fastify/fastify-rate-limit#333 |
Should we pin specifically to |
|
Also, maybe we can also work on centralizing all CI workflows (and possibly most scripts) during this release cycle I see that some repos use WDYT? CC @Eomm |
|
We have centralized all the main extranal software such as redis. so I think it is a matter of missing PR or unsupported versions Right now the releases are going to change: we are waiting the OpenJS Foundation as npm provenance signature host |
|
As part of pinning tap, Dependabot configs also needs to be updated to ignore major tap versions to stop it from opening PRs, see: fastify/.github/dependabot.yml Lines 35 to 37 in 396b8b9 |
|
A reminder that we have this notion page to see all the public repos and download stats: |
|
Just wanted to put a checklist of items to look at when updating a package that I have found so far. These won't apply for every repo, but they should be checked if they apply or not for every repo. I'll keep adding to this as I find anything else. (Feel free to edit/update this comment or copy it into the main issue summary.)
|
|
We may not need to pin tap: openjs-foundation/cross-project-council#1170 (comment) |
|
I am keeping up with that thread (as you probably can see). I will update the task list here if it comes about in time that Blue Oak is authorized. But we can bump |
|
Maybe we should archive the docs-chinese, docs-portuguese and docs-korean, as there is basically no activity. |
|
We can not upgrade tap in any repo that supports node v14, so it'd be a Fastify v5 affair. As far as it seems, Blue Oak is on track to be OSI approved in a month. If it's not, then we would need to migrate (seems very unlikely). |
|
I think it's mostly safe for v5 to upgrade to latest tap. |
|
fastify-dx is archived, it can be marked as done |
|
Hey everyone, us, the team at Nearform has been doing an amazing job over the past week to upgrade as many plugins as possible to be ready for Fastify v5. We've also put together a comprehensive list of all the plugins, along with additional links to the PRs we've opened and NPM Stats for repositories that we believe are no longer in use or not worth upgrading. However, the decision on whether to upgrade these repositories is ultimately up to you. ❌ - closed without merge
|
|
This is absolutely amazing, especially since I also had some ideas about archiving a few of the repos Thank you so much |
|
@synapse small issue with the list showing dead packages, some packages were checked against the wrong names For instance we should check for These (and potentially others) seem to be wrong: I can't edit comments so can't fix it manually, would be appreciated if you could take a look |
|
Hey @gurgunday sorry for that, I've rechecked all repos previously marked as to be archived. Indeed the NPM naming was different from the repo name. I've updated them, fortunately there were only a few of them off. I also left you the markdown source there in case you want to update the main one. |
|
Ah crud, just realised we missed something. |
|
I think someone said doing that without first releasing a version of Haven't looked at the code though so not sure |
|
The fastify plugin seems to support multiple versions by using Semver ranges. https://github.com/fastify/fastify-plugin?tab=readme-ov-file#fastify-version Somebody from the fastify team should probably share what is expected, but I would guess something like the below.
Once the next branch is updated, if it only supports v5 then that branch won’t be usable until a v5 version is released. It might make sense to wait for an alpha or beta version of v5 that can be used before making that change. Or, doing an alpha release solely for this reason. |
Ah yeah, good point. Ignore me 😹 |
|
@nrayburn-tech yeah We should release an alpha/beta very soon, as soon as we can rebase Then we (or @Fdawgs, who is good at this 😄) can run a script to mass update |
|
it looks all the plugins / repos are in one of this 2 statuses:
v5 is near 🥳 |
|
Thanks everybody. I'd like to mention especially @synapse, @bilalshareef, @puskin94 and @Gesma94 who have contributed this work on behalf of Nearform. |
|
Is there anything else that needs support to get this over the line? |
|
Other than a few small issues in repos like restartable and autoload, we're nearly done with plugin updates I will propose archiving a few plugins, so I haven't updated them, but the rest is complete I think We should start doing prereleases of v5 soon |
|
If there's any other support needed, just ping me. |
To prepare for v5 we need to go through the list of repositories in this issue and:
Note: we must pinBlue Oak is now OSI approved (https://opensource.org/license/blue-oak-model-license/), thus solving the licensing issue on this dependency.tap@16.3.9for any projects utilizing it. See Update modules for v5 #5116 (comment) for a required change related to this.If you are interested in helping with any of these, please create a new issue in the repo you're interested in that has the title "Updating for v5" and a body with something like "👋 I'm X, and would like to work on this." It should also include a link back to this issue. After that issue is created, a member of the Fastify team will create a
nextbranch for you to target. Once that branch is created, you will be able to start a new Pull Request that targets it. We will help out with any questions you may have.Footnote 1
Regarding updating the CI configuration in these projects. Most projects in the list should have a CI workflow that looks like https://github.com/fastify/fast-content-type-parse/blob/4de4e57f2d2c2893094c2a46069e04767b179d8e/.github/workflows/ci.yml#L1-L23. Thus, we have a few possible changes:
v4tag of the worklows repo once issue Create a v4 set workflows#106 has been resolved.The text was updated successfully, but these errors were encountered: