If accepted, we could send a PR.

I think it would be better to make it a factory function option that gets cached as we do with other things of this nature. It would remove the function invocation cost at every request and make it a symbol lookup.

Otherwise, seems reasonable to me.

a factory function option that gets cached as we do with other things of this nature

@jsumners Can you point to any part of existing code that does this?

It would remove the function invocation cost at every request and make it a symbol lookup.

How would that work if we may need to dynamically recalculate the message for every request?

https://github.com/fastify/fastify/blob/660eea97b094de11d2619d711c1313fb3caba567/lib/route.js

It would remove the function invocation cost at every request and make it a symbol lookup.

How would that work if we may need to dynamically recalculate the message for every request?

Your original statement was suggesting only the replacement of the text string "incoming request". The dynamic nature of the replacement was not explicitly stated. In that case, yes, it would need to be a function.

I mentioned that it would make sense to incorporate request details, otherwise not much benefit over original

I would not change that log, since it is much easier adding a onRequest/onSend hook to customize the log message.

The big deal here would be: could we create a plugin that adds those hooks AND takes control of the disableRequestLogging server's option?
Right now, it is not possible, but often I would like to customize the server's option from a plugin

Hello, I want to attempt to tackle this issue. Please let me know if this issue no longer needs assistance.

Sure, how do you plan to tackle this issue?

Sure, how do you plan to tackle this issue?

Ok thanks! I would like to create a request param log message which will provide a detailed overview of each request, ideally something that is similar to the layout of Window's Event Viewer. I also think kibertoad's original idea to create a new function called createRequestLogMessage(req) is perfect and I would like to incorporate that in the project if possible. Therefore, here's how I would like the message to be structured:

------------------------------------ Incoming Request ------------------------------------

| Date and Time | HTTP Method | Request IP Address | Request URL |

new Date or 		req.method			req.ip					req.url
req.timestamp 

————————————————————————————————————————————————-

Or maybe have the layout look like something similar to this:



------------------------------------ Incoming Request ------------------------------------
Date and Time: new Date() or req.timestamp

HTTP Method: req.method

Request IP address: req.ip



Request URL: req.url

————————————————————————————————————————————————-

The syntax would be located in fastify.js, unless advised elsewhere, and would look similar to this:


const date = new Date();




// Please let me know if you’d prefer req.timestamp instead
const DateAndTime = {
seconds: date.getSeconds(),
minutes: (date.getMinutes() < 10) ? '0' + date.getMinutes() : '' + date.getMinutes(),
hours: (date.getHours() >= 13) ? date.getHours() % 12 : date.getHours(),
days : date.getDate(),
months: date.getMonth() + 1,
years: date.getFullYear(),
meridiem: date.getHours() >= 12 ? 'PM' : 'AM',
};


const LogData = {


incomingRequest : '------------------------------------ Incoming Request ------------------------------------'
categories : '| Date and Time | HTTP Method | Request IP Address | Request URL |'
underLine : ‘————————————————————————————————————————————————-‘
}

const app = fastify({
createRequestLogMessage: (req,DateAndTime,LogData) => {



// Declare timestamp variable
const timestamp = ${DateAndTime.months}/${DateAndTime.days}/${DateAndTime.years} ${DateAndTime.hours}:${DateAndTime.minutes}:${DateAndTime.seconds} ${DateAndTime.meridiem}

const properties = `	${timestamp}		${req.method}	${req.ip}		${req.url}	`;

return '${LogData.incomingRequest}\n${LogData.categories}\n${properties}\n${LogData.underLine}'

}
});

Please let me know if you have any recommendations or critiques and I will make sure to adjust my plan accordingly. Thank you again.

The createRequestLogMessage signature looks sound. Have you considered only passing the request object? At that point in time, the Request instance has been made, for instance, most of the information from the request is already parsed and we pass it to the function to enable it to create its own message.

What do you think?

The createRequestLogMessage signature looks sound. Have you considered only passing the request object? At that point in time, the Request instance has been made, for instance, most of the information from the request is already parsed and we pass it to the function to enable it to create its own message.

What do you think?

Hi @metcoder95, I agree that's a good point thank you for letting me know.

Please let me know what you think of my revised version:




const app = fastify({
createRequestLogMessage: (req) => {



const date = new Date();




// Please let me know if you’d prefer req.timestamp instead
const DateAndTime = {
seconds: date.getSeconds(),
minutes: (date.getMinutes() < 10) ? '0' + date.getMinutes() : '' + date.getMinutes(),
hours: (date.getHours() >= 13) ? date.getHours() % 12 : date.getHours(),
days : date.getDate(),
months: date.getMonth() + 1,
years: date.getFullYear(),
meridiem: date.getHours() >= 12 ? 'PM' : 'AM',
};


const LogData = {


incomingRequest : '------------------------------------ Incoming Request ------------------------------------'
categories : '| Date and Time | HTTP Method | Request IP Address | Request URL |'
underLine : ‘————————————————————————————————————————————————-‘
}


// Declare timestamp variable
const timestamp = ${DateAndTime.months}/${DateAndTime.days}/${DateAndTime.years} ${DateAndTime.hours}:${DateAndTime.minutes}:${DateAndTime.seconds} ${DateAndTime.meridiem}

const properties = ${timestamp} ${req.method} ${req.ip} ${req.url} ;

return ${LogData.incomingRequest}\n${LogData.categories}\n${properties}\n${LogData.underLine};
}
});

Or perhaps

const app = fastify({
createRequestLogMessage: (req) => {




const LogData = {


incomingRequest : '------------------------------------ Incoming Request ------------------------------------'
categories : '| Date and Time | HTTP Method | Request IP Address | Request URL |'
underLine : ‘————————————————————————————————————————————————-‘
}


const properties = ${req.timestamp} ${req.method} ${req.ip} ${req.url} ;

return ${LogData.incomingRequest}\n${LogData.categories}\n${properties}\n${LogData.underLine};
}
});

Please let me know if you have any questions. Thank you.

the code above is not very readable.

Go ahead and send a PR but do not alter the current message.

the code above is not very readable.

Go ahead and send a PR but do not alter the current message.

My apologies I'll make sure to have it more organized moving forward. But Just to make sure would the current message I don't want to alter be:

if (disableRequestLogging === false) { childLogger.info({ req: request }, 'incoming request') }

Thanks.

As @mcollina pointed out, might be better to see a PR

But Just to make sure would the current message I don't want to alter be:

if (disableRequestLogging === false) { childLogger.info({ req: request }, 'incoming request') }

Yes, if the createRequestLogMessage is not passed, the current message should prevail

Ok gotcha, I'll make sure to leave that the way it is. Please let me know if you have anymore questions about this and thank you again for all your help.