Undefined is a valid value for if set as a single hook #4351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Collina <hello@matteocollina.com>
delvedor
approved these changes
Oct 17, 2022
Uzlopak
approved these changes
Oct 17, 2022
climba03003
approved these changes
Oct 17, 2022
SimenB
reviewed
Oct 18, 2022
| async handler () { | ||
| return 'hello world' | ||
| } | ||
| }) | ||
| }, new Error('onRequest hook should be a function, instead got undefined')) | ||
| }, new Error('onRequest hook should be a function, instead got object')) |
There was a problem hiding this comment.
instead got object is weird - better to check for null and print that? or util.inspect perhaps
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately #4332 was too restrictive and it broke quite a few of our modules, e.g. https://github.com/fastify/fastify-http-proxy/blob/72703f28db516652fdd0fd08f17e269f8947b6b3/index.js#L221 has the value as
undefined. This makes it less restrictive by allowingundefinedas a value for single-level hooks.Given that the case mentioned in #4320 was about arrays I think it's ok to land this.
Checklist
npm run testandnpm run benchmarkand the Code of conduct