Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add test examples with undici and fetch #4300

Merged
merged 1 commit into from Oct 6, 2022
Merged

docs: add test examples with undici and fetch #4300

merged 1 commit into from Oct 6, 2022

Conversation

ghost
Copy link

@ghost ghost commented Sep 23, 2022

Resolves #4296.

Checklist

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 23, 2022
docs/Guides/Testing.md Outdated Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that you should keep keepAliveTimeout and keepAliveTimeoutMax set low (like 10): https://undici.nodejs.org/#/docs/api/Client?id=parameter-clientoptions. Otherwise in Node.js v16 and v14 the test will keep running for long.

(verify this!)

@ghost ghost requested review from jsumners and mcollina and removed request for jsumners and mcollina September 26, 2022 06:21
@ghost ghost requested review from jsumners and mcollina and removed request for jsumners and mcollina September 26, 2022 11:42
docs/Guides/Testing.md Outdated Show resolved Hide resolved
@ghost ghost requested review from L2jLiga and jsumners and removed request for mcollina, L2jLiga and jsumners October 3, 2022 06:33
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ghost ghost requested review from Uzlopak, jsumners and L2jLiga and removed request for jsumners, Uzlopak and L2jLiga October 3, 2022 08:21
Copy link
Member

@L2jLiga L2jLiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ghost ghost requested review from simoneb and removed request for jsumners October 4, 2022 12:04
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we must include the same example twice, the second example should have a preface describing why it is included.

@ghost ghost requested review from jsumners and removed request for simoneb October 4, 2022 13:34
@ghost
Copy link
Author

ghost commented Oct 4, 2022

@jsumners I added a description of the second example:
This example is a copy of the previous one, this time using fetch to make the request.

docs/Guides/Testing.md Outdated Show resolved Hide resolved
@ghost ghost requested review from simoneb and jsumners and removed request for simoneb October 4, 2022 15:33
@ghost ghost requested a review from simoneb October 5, 2022 06:10
@mcollina mcollina merged commit 62d2c94 into fastify:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Testing - request package has been deprecated
6 participants