New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: backport reused connection fix #4217

Merged

mcollina merged 1 commit into fastify:3.x from salzhrani:fix/open-connection-issue-backport

Aug 30, 2022

salzhrani commented Aug 24, 2022

this PR is a back-port of the work done in this PR to the 3.x branch

Checklist

run npm run test and npm run benchmark
tests and/or benchmarks are included
documentation is changed or added
commit message and code follows the Developer's Certification of Origin
and the Code of conduct

salzhrani mentioned this pull request

fix: default clientError replies on reused connection (#4101) #4133

Merged

4 tasks

mcollina approved these changes

View reviewed changes

Member

mcollina left a comment

lgtm

jsumners reviewed

View reviewed changes

fastify.js Show resolved Hide resolved

jsumners approved these changes

View reviewed changes

Member

jsumners left a comment

Looks good to me.

Member

mcollina commented Aug 24, 2022

 FAIL  test/request-error.test.js 1 failed of 31 498.848ms
 ✖ should match pattern provided

CI is failing on node 10

Author

salzhrani commented Aug 25, 2022

it seems in node v10 calling destroy here can cause the stream not to drain, and no data chunks reach the client. hence the failed test. I would try end instead of destroy but it causes another test to fail. not sure where to go from here

Member

mcollina commented Aug 25, 2022

Maybe make the switch conditional depending on the major version of Node.js.

Author

salzhrani commented Aug 25, 2022

Can you elaborate please?

Member

mcollina commented Aug 25, 2022

Let's try skipping the test if it's node v10.


          fix: backport reused connection fix

18f2bf8

salzhrani force-pushed the fix/open-connection-issue-backport branch from 33f7b3c to 18f2bf8 Compare

August 28, 2022 06:32

mcollina approved these changes

View reviewed changes

Member

mcollina left a comment

lgtm

Author

salzhrani commented Aug 28, 2022

suggestion applied @mcollina

mcollina approved these changes

View reviewed changes

Member

mcollina left a comment

lgtm

mcollina merged commit 76c38d2 into fastify:3.x

renovate bot added a commit to apollographql/apollo-server that referenced this pull request


          chore(deps): update all non-major dependencies (main) (#6852)

2bf7f66

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@graphql-tools/mock](https://togithub.com/ardatan/graphql-tools) |
[`8.7.3` ->
`8.7.6`](https://renovatebot.com/diffs/npm/@graphql-tools%2fmock/8.7.3/8.7.6)
|
[![age](https://badges.renovateapi.com/packages/npm/@graphql-tools%2fmock/8.7.6/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@graphql-tools%2fmock/8.7.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@graphql-tools%2fmock/8.7.6/compatibility-slim/8.7.3)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@graphql-tools%2fmock/8.7.6/confidence-slim/8.7.3)](https://docs.renovatebot.com/merge-confidence/)
|
| [@graphql-tools/utils](https://togithub.com/ardatan/graphql-tools) |
[`8.10.0` ->
`8.12.0`](https://renovatebot.com/diffs/npm/@graphql-tools%2futils/8.10.0/8.12.0)
|
[![age](https://badges.renovateapi.com/packages/npm/@graphql-tools%2futils/8.12.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@graphql-tools%2futils/8.12.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@graphql-tools%2futils/8.12.0/compatibility-slim/8.10.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@graphql-tools%2futils/8.12.0/confidence-slim/8.10.0)](https://docs.renovatebot.com/merge-confidence/)
|
|
[@types/aws-lambda](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/aws-lambda)
([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) |
[`8.10.102` ->
`8.10.104`](https://renovatebot.com/diffs/npm/@types%2faws-lambda/8.10.102/8.10.104)
|
[![age](https://badges.renovateapi.com/packages/npm/@types%2faws-lambda/8.10.104/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@types%2faws-lambda/8.10.104/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@types%2faws-lambda/8.10.104/compatibility-slim/8.10.102)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@types%2faws-lambda/8.10.104/confidence-slim/8.10.102)](https://docs.renovatebot.com/merge-confidence/)
|
|
[@types/express](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/express)
([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) |
[`4.17.13` ->
`4.17.14`](https://renovatebot.com/diffs/npm/@types%2fexpress/4.17.13/4.17.14)
|
[![age](https://badges.renovateapi.com/packages/npm/@types%2fexpress/4.17.14/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@types%2fexpress/4.17.14/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@types%2fexpress/4.17.14/compatibility-slim/4.17.13)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@types%2fexpress/4.17.14/confidence-slim/4.17.13)](https://docs.renovatebot.com/merge-confidence/)
|
|
[@types/express-serve-static-core](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/express-serve-static-core)
([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) |
[`4.17.30` ->
`4.17.31`](https://renovatebot.com/diffs/npm/@types%2fexpress-serve-static-core/4.17.30/4.17.31)
|
[![age](https://badges.renovateapi.com/packages/npm/@types%2fexpress-serve-static-core/4.17.31/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@types%2fexpress-serve-static-core/4.17.31/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@types%2fexpress-serve-static-core/4.17.31/compatibility-slim/4.17.30)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@types%2fexpress-serve-static-core/4.17.31/confidence-slim/4.17.30)](https://docs.renovatebot.com/merge-confidence/)
|
|
[@types/lodash](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/lodash)
([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) |
[`4.14.184` ->
`4.14.185`](https://renovatebot.com/diffs/npm/@types%2flodash/4.14.184/4.14.185)
|
[![age](https://badges.renovateapi.com/packages/npm/@types%2flodash/4.14.185/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@types%2flodash/4.14.185/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@types%2flodash/4.14.185/compatibility-slim/4.14.184)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@types%2flodash/4.14.185/confidence-slim/4.14.184)](https://docs.renovatebot.com/merge-confidence/)
|
| [fastify](https://www.fastify.io/)
([source](https://togithub.com/fastify/fastify)) | [`3.29.1` ->
`3.29.2`](https://renovatebot.com/diffs/npm/fastify/3.29.1/3.29.2) |
[![age](https://badges.renovateapi.com/packages/npm/fastify/3.29.2/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/fastify/3.29.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/fastify/3.29.2/compatibility-slim/3.29.1)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/fastify/3.29.2/confidence-slim/3.29.1)](https://docs.renovatebot.com/merge-confidence/)
|
| [jest-junit](https://togithub.com/jest-community/jest-junit) |
[`14.0.0` ->
`14.0.1`](https://renovatebot.com/diffs/npm/jest-junit/14.0.0/14.0.1) |
[![age](https://badges.renovateapi.com/packages/npm/jest-junit/14.0.1/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/jest-junit/14.0.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/jest-junit/14.0.1/compatibility-slim/14.0.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/jest-junit/14.0.1/confidence-slim/14.0.0)](https://docs.renovatebot.com/merge-confidence/)
|
| [rollup](https://rollupjs.org/)
([source](https://togithub.com/rollup/rollup)) | [`2.78.1` ->
`2.79.1`](https://renovatebot.com/diffs/npm/rollup/2.78.1/2.79.1) |
[![age](https://badges.renovateapi.com/packages/npm/rollup/2.79.1/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/rollup/2.79.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/rollup/2.79.1/compatibility-slim/2.78.1)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/rollup/2.79.1/confidence-slim/2.78.1)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>ardatan/graphql-tools (@&#8203;graphql-tools/mock)</summary>

###
[`v8.7.6`](https://togithub.com/ardatan/graphql-tools/blob/HEAD/packages/mock/CHANGELOG.md#&#8203;876)

[Compare
Source](https://togithub.com/ardatan/graphql-tools/compare/@graphql-tools/mock@8.7.5...@graphql-tools/mock@8.7.6)

##### Patch Changes

- Updated dependencies
\[[`43c736bd`](https://togithub.com/ardatan/graphql-tools/commit/43c736bd1865c00898966a7ed14060496c9e6a0c)]:
-
[@&#8203;graphql-tools/utils](https://togithub.com/graphql-tools/utils)[@&#8203;8](https://togithub.com/8).12.0
-
[@&#8203;graphql-tools/schema](https://togithub.com/graphql-tools/schema)[@&#8203;9](https://togithub.com/9).0.4

###
[`v8.7.5`](https://togithub.com/ardatan/graphql-tools/blob/HEAD/packages/mock/CHANGELOG.md#&#8203;875)

[Compare
Source](https://togithub.com/ardatan/graphql-tools/compare/@graphql-tools/mock@8.7.4...@graphql-tools/mock@8.7.5)

##### Patch Changes

- Updated dependencies
\[[`71cb4fae`](https://togithub.com/ardatan/graphql-tools/commit/71cb4faeb0833a228520a7bc2beed8ac7274443f),
[`403ed450`](https://togithub.com/ardatan/graphql-tools/commit/403ed4507eff7cd509f410f7542a702da72e1a9a)]:
-
[@&#8203;graphql-tools/utils](https://togithub.com/graphql-tools/utils)[@&#8203;8](https://togithub.com/8).11.0
-
[@&#8203;graphql-tools/schema](https://togithub.com/graphql-tools/schema)[@&#8203;9](https://togithub.com/9).0.3

###
[`v8.7.4`](https://togithub.com/ardatan/graphql-tools/blob/HEAD/packages/mock/CHANGELOG.md#&#8203;874)

[Compare
Source](https://togithub.com/ardatan/graphql-tools/compare/@graphql-tools/mock@8.7.3...@graphql-tools/mock@8.7.4)

##### Patch Changes

- Updated dependencies
\[[`4fe3d9c0`](https://togithub.com/ardatan/graphql-tools/commit/4fe3d9c037e9c138bd8a9b04b3977d74eba32c97)]:
-
[@&#8203;graphql-tools/utils](https://togithub.com/graphql-tools/utils)[@&#8203;8](https://togithub.com/8).10.1
-
[@&#8203;graphql-tools/schema](https://togithub.com/graphql-tools/schema)[@&#8203;9](https://togithub.com/9).0.2

</details>

<details>
<summary>ardatan/graphql-tools (@&#8203;graphql-tools/utils)</summary>

###
[`v8.12.0`](https://togithub.com/ardatan/graphql-tools/blob/HEAD/packages/utils/CHANGELOG.md#&#8203;8120)

[Compare
Source](https://togithub.com/ardatan/graphql-tools/compare/@graphql-tools/utils@8.11.0...@graphql-tools/utils@8.12.0)

##### Minor Changes

- [#&#8203;4706](https://togithub.com/ardatan/graphql-tools/pull/4706)
[`43c736bd`](https://togithub.com/ardatan/graphql-tools/commit/43c736bd1865c00898966a7ed14060496c9e6a0c)
Thanks [@&#8203;ardatan](https://togithub.com/ardatan)! - Do not throw
duplicate type error name while rewiring types

###
[`v8.11.0`](https://togithub.com/ardatan/graphql-tools/blob/HEAD/packages/utils/CHANGELOG.md#&#8203;8110)

[Compare
Source](https://togithub.com/ardatan/graphql-tools/compare/@graphql-tools/utils@8.10.1...@graphql-tools/utils@8.11.0)

##### Minor Changes

- [#&#8203;4661](https://togithub.com/ardatan/graphql-tools/pull/4661)
[`403ed450`](https://togithub.com/ardatan/graphql-tools/commit/403ed4507eff7cd509f410f7542a702da72e1a9a)
Thanks [@&#8203;nicolaslt](https://togithub.com/nicolaslt)! - Add
getArgumentsWithDirectives

##### Patch Changes

- [#&#8203;4694](https://togithub.com/ardatan/graphql-tools/pull/4694)
[`71cb4fae`](https://togithub.com/ardatan/graphql-tools/commit/71cb4faeb0833a228520a7bc2beed8ac7274443f)
Thanks [@&#8203;dimatill](https://togithub.com/dimatill)! - Fix
pruneSchema to not remove type that is used only as a directive argument
type

###
[`v8.10.1`](https://togithub.com/ardatan/graphql-tools/blob/HEAD/packages/utils/CHANGELOG.md#&#8203;8101)

[Compare
Source](https://togithub.com/ardatan/graphql-tools/compare/@graphql-tools/utils@8.10.0...@graphql-tools/utils@8.10.1)

##### Patch Changes

- [#&#8203;4673](https://togithub.com/ardatan/graphql-tools/pull/4673)
[`4fe3d9c0`](https://togithub.com/ardatan/graphql-tools/commit/4fe3d9c037e9c138bd8a9b04b3977d74eba32c97)
Thanks [@&#8203;thgreasi](https://togithub.com/thgreasi)! - Fix typings
for TypeScript 4.8

</details>

<details>
<summary>fastify/fastify</summary>

###
[`v3.29.2`](https://togithub.com/fastify/fastify/releases/tag/v3.29.2)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v3.29.1...v3.29.2)

##### What's Changed

- fix: backport reused connection fix by
[@&#8203;salzhrani](https://togithub.com/salzhrani) in
[fastify/fastify#4217

##### New Contributors

- [@&#8203;salzhrani](https://togithub.com/salzhrani) made their first
contribution in
[fastify/fastify#4217

**Full Changelog**:
fastify/fastify@v3.29.1...v3.29.2

</details>

<details>
<summary>jest-community/jest-junit</summary>

###
[`v14.0.1`](https://togithub.com/jest-community/jest-junit/releases/tag/v14.0.1)

[Compare
Source](https://togithub.com/jest-community/jest-junit/compare/v14.0.0...v14.0.1)

Prevent unnecessary duplicate test cases by
[@&#8203;azzlack](https://togithub.com/azzlack) -
[jest-community/jest-junit#221

</details>

<details>
<summary>rollup/rollup</summary>

###
[`v2.79.1`](https://togithub.com/rollup/rollup/blob/HEAD/CHANGELOG.md#&#8203;2791)

[Compare
Source](https://togithub.com/rollup/rollup/compare/v2.79.0...v2.79.1)

*2022-09-22*

##### Bug Fixes

- Avoid massive performance degradation when creating thousands of
chunks ([#&#8203;4643](https://togithub.com/rollup/rollup/issues/4643))

##### Pull Requests

- [#&#8203;4639](https://togithub.com/rollup/rollup/pull/4639): fix:
typo docs and contributors link in CONTRIBUTING.md
([@&#8203;takurinton](https://togithub.com/takurinton))
- [#&#8203;4641](https://togithub.com/rollup/rollup/pull/4641): Update
type definition of resolveId
([@&#8203;ivanjonas](https://togithub.com/ivanjonas))
- [#&#8203;4643](https://togithub.com/rollup/rollup/pull/4643): Improve
performance of chunk naming collision check
([@&#8203;lukastaegert](https://togithub.com/lukastaegert))

###
[`v2.79.0`](https://togithub.com/rollup/rollup/blob/HEAD/CHANGELOG.md#&#8203;2790)

[Compare
Source](https://togithub.com/rollup/rollup/compare/v2.78.1...v2.79.0)

*2022-08-31*

##### Features

- Add `amd.forceJsExtensionForImports` to enforce using `.js` extensions
for relative AMD imports
([#&#8203;4607](https://togithub.com/rollup/rollup/issues/4607))

##### Pull Requests

- [#&#8203;4607](https://togithub.com/rollup/rollup/pull/4607): add
option to keep extensions for amd
([@&#8203;wh1tevs](https://togithub.com/wh1tevs))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click
this checkbox.

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/apollographql/apollo-server).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNzYuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIwMS4zIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

salzhrani deleted the fix/open-connection-issue-backport branch

July 17, 2023 12:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment