New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 4204 #4205
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I really think we should tidy up the code afterward (e.g. refactor, or comment for code flow). |
I agree! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #4204
Checklist
npm run test
andnpm run benchmark
and the Code of conduct