Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add fastify.display-name symbol #4191

Merged
merged 4 commits into from Aug 13, 2022
Merged

doc: add fastify.display-name symbol #4191

merged 4 commits into from Aug 13, 2022

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Aug 10, 2022

No description provided.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 10, 2022
@Eomm Eomm mentioned this pull request Aug 10, 2022
Merged
mcollina
mcollina approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

RafaelGSS
RafaelGSS reviewed Aug 10, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above statement needs to be updated as well

Name of the current plugin. The root plugin is called `'fastify'`. There are
- three ways to define a name (in order).
+ four ways to define a name (in order).

@Eomm Eomm requested a review from RafaelGSS August 11, 2022 05:47
simoneb
simoneb reviewed Aug 11, 2022
View reviewed changes
docs/Reference/Server.md Outdated Show resolved Hide resolved
Eomm and others added 2 commits August 11, 2022 19:03
@Eomm @simoneb
Update docs/Reference/Server.md
4fd4f7f 
Co-authored-by: Simone Busoli <simone.busoli@gmail.com>
@Eomm
fix: lint
47bd882
RafaelGSS
RafaelGSS approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Eomm Eomm merged commit 37ae4ea into main Aug 13, 2022
@Eomm Eomm deleted the meta-plugin-name branch August 13, 2022 07:02
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simoneb simoneb simoneb left review comments

@mcollina mcollina mcollina approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Eomm @simoneb @mcollina @RafaelGSS