add unit test for ajv-formats #4187
Conversation
github-actions
bot
added
the
test
| const fastify = Fastify({ | ||
| ajv: { | ||
| plugins: [ | ||
| require('ajv-formats') |
There was a problem hiding this comment.
It is actually added by @fastify/ajv-compiler.
The only exception is when you apply your own ajv-formats, it will override the ajv-formats in @fastify/ajv-compiler
There was a problem hiding this comment.
I had no idea ajv-formats was included with Fastify via @fastify/ajv-compiler — that's great! I don't see it mentioned in the Validation documentation, but I'd be happy to open a PR that adds this in.
As far as I can tell, ajv-formats wasn't included with Fastify v3 — is that correct?
There was a problem hiding this comment.
As far as I can tell, ajv-formats wasn't included with Fastify v3 — is that correct?
No, ajv-formats is embedded inside ajv@6.
It is extracted in ajv@7 and we need to explicitly add it through ajv-formats.
See More: https://github.com/ajv-validator/ajv/releases/tag/v7.0.0
There was a problem hiding this comment.
Oh that's right, I forgot about that. And Fastify went from Ajv v6 (formats embedded) -> v8 (formats in ajv-formats)?
|
I guess an added unit test is always useful! |
This reverts commit ea8aae9.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
We have ajv-formats in devDependencies but dont use it anywhere. In order to check if ajv-formats does work in regards to fastify/help#732 I wrote the test to ensure that it should work.
Checklist
npm run testandnpm run benchmarkand the Code of conduct