New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove http2 experimental status (#4142) #4144
docs: remove http2 experimental status (#4142) #4144
Conversation
docs/Reference/HTTP2.md
Outdated
_Fastify_ supports HTTP2 starting from Node 8 LTS, | ||
which includes HTTP2 without a flag; HTTP2 is supported over either HTTPS or | ||
plaintext. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_Fastify_ supports HTTP2 starting from Node 8 LTS, | |
which includes HTTP2 without a flag; HTTP2 is supported over either HTTPS or | |
plaintext. | |
_Fastify_ supports HTTP2 over either HTTPS or plaintext (h2). |
I would simplify the full sentence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplifying sounds good. But don't you mean HTTPS (h2) or plaintext (h2c)
instead?
i'm asking because the HTTP/2 spec states:
The string "h2" identifies the protocol where HTTP/2 uses Transport Layer Security (TLS) [TLS12].
The string "h2c" identifies the protocol where HTTP/2 is run over cleartext TCP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot, I meant h2c
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Checklist
npm run test
andnpm run benchmark
and the Code of conduct