Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make type provider-provided return types be enforced #4089

Merged
merged 2 commits into from Jun 26, 2022
Merged

Make type provider-provided return types be enforced #4089

merged 2 commits into from Jun 26, 2022

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Jun 26, 2022

Fixes #4088

Checklist

@github-actions github-actions bot added the typescript TypeScript related label Jun 26, 2022
@sinclairzx81
Copy link
Contributor

@A5rocks This looks good to me :) Nice work!

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 5856a46 into fastify:main Jun 26, 2022
@A5rocks A5rocks deleted the fix-return-types branch June 27, 2022 03:08
@A5rocks
Copy link
Contributor Author

A5rocks commented Jun 27, 2022

Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typescript TypeScript related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return type not correctly set with type providers
3 participants