Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (test): custom-parser.test.js flaky test #3627

Merged
merged 3 commits into from Jan 17, 2022
Merged

fix (test): custom-parser.test.js flaky test #3627

merged 3 commits into from Jan 17, 2022

Conversation

darkgl0w
Copy link
Member

@darkgl0w darkgl0w commented Jan 16, 2022 •
edited

Hello.

As titled this PR aims to fix and close #3626

Checklist

@github-actions github-actions bot added the test Issue or pr related to our testing infrastructure. label Jan 16, 2022
mcollina
mcollina approved these changes Jan 16, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

RafaelGSS
RafaelGSS approved these changes Jan 16, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

climba03003
climba03003 requested changes Jan 17, 2022
View reviewed changes
test/custom-parser.test.js Outdated Show resolved Hide resolved
@darkgl0w @climba03003
fix (test): apply @climba03003 code review
7255ae1 
Co-authored-by: KaKa <climba03003@gmail.com>
climba03003
climba03003 approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Eomm
Eomm reviewed Jan 17, 2022
View reviewed changes
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would improve the readability a bit

test/custom-parser.test.js Outdated Show resolved Hide resolved
test/custom-parser.test.js Outdated Show resolved Hide resolved
@darkgl0w @Eomm
refactor (test): apply @Eomm code review
37d5555 
- improve code readability

Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
@Eomm Eomm merged commit dd7de59 into fastify:main Jan 17, 2022
@darkgl0w darkgl0w deleted the flackyness-fighting branch January 17, 2022 13:08
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@Eomm Eomm Eomm approved these changes

@climba03003 climba03003 climba03003 approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
test Issue or pr related to our testing infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test (ci): custom-parser.test.js is randomly failing with a 503 Service Unavailable
5 participants
@darkgl0w @mcollina @Eomm @climba03003 @RafaelGSS