fix (types): this is FastifyInstance

[darkgl0w]

Hello.

This PR aims to :

• change typescript definitions of thisto FastifyInstance (fix A change in Fastify hook types broke our hooks #3620)
• add a typescript test to avoid regressions
• fix a flaky 404s.test.js test randomly timing out

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[climba03003]

Can you add an unit test for this changes? Not compulsory, but better to prevent the this problem in future.

[mcollina]

can you please add an assertion so we don't regress?

[darkgl0w]

Yeah I will be home in maybe 10/15 minutes.
I will add a proper use case to prevent any future regression on this.

[mcollina]

lgtm

[mcollina]

@climba03003 could you take a final look? I plan to ship this tomorrow.

[climba03003]

LGTM.

[darkgl0w]

CI fails on what appears to be an unrelated flacky test :d

Hmmm, ok at least 2 flacky tests spotted:

• the 1st one is in the 404s.test.js file at line 1224. IMO it can be fixed by passing the tap timeout option :

- t.test('preHandler hook in setNotFoundHandler should be called when callNotFound', t => {
+ t.test('preHandler hook in setNotFoundHandler should be called when callNotFound', { timeout: 40000 }, t => {

• the 2nd one is in the custom-parser.test.js file at line 1381.
  It returns a 503 HTTP status code (Service Unavailable) instead of the 200 expected one. I will try to see if it can be fixed :d

[darkgl0w]

CI is all green on my branch 😠 https://github.com/darkgl0w/fastify/actions/runs/1704685094

I will open a new PR when I figure out how to fix the flacky test in the custom-parser.test.js file.

[mcollina]

CI fails on what appears to be an unrelated flacky test :d

Hmmm, ok at least 2 flacky tests spotted:

• the 1st one is in the 404s.test.js file at line 1224. IMO it can be fixed by passing the tap timeout option :

- t.test('preHandler hook in setNotFoundHandler should be called when callNotFound', t => {

+ t.test('preHandler hook in setNotFoundHandler should be called when callNotFound', { timeout: 40000 }, t => {

• the 2nd one is in the custom-parser.test.js file at line 1381.

It returns a 503 HTTP status code (Service Unavailable) instead of the 200 expected one. I will try to see if it can be fixed :d

Could you please open a couple of issues?

[darkgl0w]

@mcollina > sure, the fix for the 404 test randomly timing out is included in this PR (I tried to reproduce it with the fix and it seems to be gone now)

And for the last one randomly returning a 503 HTTP Status I think I've got a fix. Currently running the test suite on a little Banana Pi to see if it works as it should ^^

[RafaelGSS]

LGTM.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.