New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding esbuild bundler to the pipeline #3616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nitpicks
|
||
test('Bundled package should work', t => { | ||
t.plan(1) | ||
fastifySuccess.ready((err) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the inject
to test if the route was registered with success
@@ -0,0 +1,14 @@ | |||
const fp = require('fastify-plugin') | |||
const fastify = require('../../../../')({ | |||
logger: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logger in this case is not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR fixes #3377: It includes esbuild tests to the package pipeline.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct