Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fast-uri with Ajv to speed up cold start #3607

Closed
2 tasks done
mcollina opened this issue Jan 8, 2022 · 1 comment
Closed
2 tasks done

Use fast-uri with Ajv to speed up cold start #3607

mcollina opened this issue Jan 8, 2022 · 1 comment
Assignees
Labels
feature request New feature to be added v4.x Issue or pr related to Fastify v4
Milestone

Comments

@mcollina
Copy link
Member

mcollina commented Jan 8, 2022

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

馃殌 Feature Proposal

A long time ago we identified the dependency uri-js as the main performance bottleneck for cold start (see garycourt/uri-js#40). Unfortunately the maintainers did not want to work in improving the performance. A few months back @zekth forked uri-js into https://github.com/fastify/fast-uri fixing that performance issues and others.

We should use this for the fastify v4 launch. To do so we need:

Motivation

No response

Example

No response

@mcollina mcollina added feature request New feature to be added v4.x Issue or pr related to Fastify v4 labels Jan 8, 2022
@mcollina mcollina added this to the v4.0.0 milestone Jan 8, 2022
@mcollina mcollina self-assigned this Jan 8, 2022
@zekth
Copy link
Member

zekth commented Feb 7, 2022

landed in : #3687

@mcollina mcollina closed this as completed Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature to be added v4.x Issue or pr related to Fastify v4
Projects
None yet
Development

No branches or pull requests

2 participants