Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types to support Ajv plugins with options #3601

Merged
merged 2 commits into from Jan 16, 2022
Merged

Fix types to support Ajv plugins with options #3601

merged 2 commits into from Jan 16, 2022

Conversation

pverdile
Copy link
Contributor

@pverdile pverdile commented Jan 6, 2022

Hi, maintainers,
I couldn't work with ajv plugins options as described in documentation Server:ajv in a typescript file, so I realized that types were incomplete.

I add the necessary types and their tests.

Checklist

@github-actions github-actions bot added the typescript TypeScript related label Jan 6, 2022
fastify.d.ts Outdated Show resolved Hide resolved
Co-authored-by: KaKa <climba03003@gmail.com>
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Eomm
Copy link
Member

Eomm commented Jan 16, 2022

ping @climba03003

Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Eomm Eomm merged commit ee795d3 into fastify:main Jan 16, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typescript TypeScript related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants