fix: remove invalid assertion

[RafaelGSS]

Ref #3017

I removed the assertion since it does not seem useful, FastifyError is an interface and in the test are being called as a function.
@Ethan-Arrowood I'm asking review for you since you've implemented it a long time ago.

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[climba03003]

I think this error is related to the changes in fastify/fastify-error@062c258.

I am +1 on removing this test case as you said FastifyError itself is only the interface and can not be construable or called directly.

Can we change the test to expectType<ValidationResult[] | undefined>(FastifyError.validation) to see if the error persist?

[RafaelGSS]

I think this error is related to the changes in fastify/fastify-error@062c258.

Agree.

Can we change the test to expectType<ValidationResult[] | undefined>(FastifyError.validation) to see if the error persist?

Not sure if it's worth it since we are checking the interface types it doesn't sound redundant for you?

[climba03003]

I think this error is related to the changes in fastify/fastify-error@062c258.

Agree.

Can we change the test to expectType<ValidationResult[] | undefined>(FastifyError.validation) to see if the error persist?

Not sure if it's worth it since we are checking the interface types it doesn't sound redundant for you?

Yes, it is. Let's wait for @Ethan-Arrowood response to see if this checking have any actual meanings.
I'm fine for both remove and modify the checking.

[mcollina]

I'm sorry but the build is broken. I need this fixed asap.

[mcollina]

lgtm

I need to ship a release and this is a blocker.

@Ethan-Arrowood PTAL

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.