Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: remove redundant conditional #3004

Merged
merged 1 commit into from Apr 13, 2021
Merged

ci: remove redundant conditional #3004

merged 1 commit into from Apr 13, 2021

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Apr 13, 2021 •
edited

  • Removed redundant conditional from automerge job
  • Sorted os matrix alphabetically
  • Removed redundant CI env variable setting as it is already set by default

Checklist

RafaelGSS
RafaelGSS approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, LGTM. I just saw the last item of PR description.

mcollina
mcollina approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 2fe1948 into fastify:main Apr 13, 2021
@Fdawgs Fdawgs deleted the patch-1 branch April 13, 2021 17:31
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Fdawgs @mcollina @RafaelGSS