New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tap15.0.1 support #2986
Tap15.0.1 support #2986
Conversation
I think the main problem is bulk replace. Some of them should not be replaced. For example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should run a local test before committing. It should fail even in local environment.
Thanks @climba03003 had a wrong select and replace inside my vscode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you double check it is not missing any of the wrong replacement? I may miss some of them when I glance through this big changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the gargantuan effort!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm huge work
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Migrate tests to tap15.0.1
Checklist
npm run test
andnpm run benchmark
and the Code of conduct