Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap15.0.1 support #2986

Merged
merged 11 commits into from Apr 8, 2021
Merged

Tap15.0.1 support #2986

merged 11 commits into from Apr 8, 2021

Conversation

veritem
Copy link
Contributor

@veritem veritem commented Apr 6, 2021

Migrate tests to tap15.0.1

Checklist

@veritem veritem changed the title Tap15 support Tap15.0.1 support Apr 6, 2021
@Eomm Eomm added dependencies Pull requests that update a dependency file test Issue or pr related to our testing infrastructure. labels Apr 6, 2021
.taprc Show resolved Hide resolved
@climba03003
Copy link
Member

climba03003 commented Apr 6, 2021

I think the main problem is bulk replace. Some of them should not be replaced.

For example:
https://github.com/fastify/fastify/blob/main/test/async-await.test.js#L425
https://github.com/makuzaverite/fastify/blob/tap15Support/test/async-await.test.js#L425

Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should run a local test before committing. It should fail even in local environment.

test/async-await.test.js Outdated Show resolved Hide resolved
test/async-await.test.js Outdated Show resolved Hide resolved
test/async-await.test.js Outdated Show resolved Hide resolved
test/async-await.test.js Outdated Show resolved Hide resolved
test/async-await.test.js Outdated Show resolved Hide resolved
test/async-await.test.js Outdated Show resolved Hide resolved
test/async-await.test.js Outdated Show resolved Hide resolved
test/async-await.test.js Outdated Show resolved Hide resolved
test/async-await.test.js Outdated Show resolved Hide resolved
test/async-await.test.js Outdated Show resolved Hide resolved
test/async-await.test.js Outdated Show resolved Hide resolved
test/async-await.test.js Outdated Show resolved Hide resolved
test/async-await.test.js Outdated Show resolved Hide resolved
@veritem
Copy link
Contributor Author

veritem commented Apr 6, 2021

Thanks @climba03003 had a wrong select and replace inside my vscode

Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you double check it is not missing any of the wrong replacement? I may miss some of them when I glance through this big changes.

test/async-await.test.js Outdated Show resolved Hide resolved
docs/Hooks.md Outdated Show resolved Hide resolved
docs/Hooks.md Outdated Show resolved Hide resolved
docs/Hooks.md Outdated Show resolved Hide resolved
docs/Hooks.md Outdated Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the gargantuan effort!

Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm huge work

@mcollina mcollina merged commit 0ae362b into fastify:main Apr 8, 2021
@github-actions
Copy link

github-actions bot commented Apr 9, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file test Issue or pr related to our testing infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants