On ready backport #2296
Merged
On ready backport #2296
+525
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding on compiler ready hook * add wip onCompilerReady hook * rename hook to onReady * onready ready * typo * add test and docs * fix test * step forward * fix tests * fix multiple resolve * improve * add decorator test * not expose boot function * better docs * improve docs Co-Authored-By: James Sumners <james@sumners.email> * Update docs/Hooks.md * fix immediate to nextTick * add types * fix test * add missing ts test * Revert "fix test" This reverts commit 671ae92. * fix ready order execution * add more test * fix hook execute once * better code * multuple ready test * fix docs add error management Co-authored-by: James Sumners <james@sumners.email>
Eomm
added
semver-minor
|
It seems CI is failing. |
|
The logger test has changed the output, I remember this issue but can't remember the cause. If you set await inject all is fine. I would like to re check better |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@Eomm any updates on this one? |
Done 👍 |
SerayaEryn
approved these changes
Jun 15, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2166
Related #2123
Checklist
npm run testandnpm run benchmark