HTTP server errors not surfaced

[gillesdemey]

Errors emitted by the HTTP server aren't passed to the listen callback, I understand that you can access the server property but surely we can do better here? :)

'use strict'

const fastify = require('fastify')

const s1 = fastify()
const s2 = fastify()

s1.listen(3000)

s2.listen(3000, err => {
  console.error(err) // no exception
})

s2.server.on('error', err => {
  console.error(err) // listen EADDRINUSE :::3000
})

[mcollina]

Errors emitted by the HTTP server aren't passed to the listen callback, I understand that you can access the server property but surely we can do better here? :)

Surely you can send a pull request, this is OSS.

Joke aside, #215 fixes it.

[gillesdemey]

Surely you can send a pull request, this is OSS.

Sorry, I thought I'd open a ticket first as a courtesy :) I'll be sure to send in a PR next time! 🙏

[delvedor]

I think @mcollina was not saying that you should fire a pr instead of an issue, he was just pointing out the tone of your issue :)

property but surely we can do better here? :)

I know it is not intended, but it sounds like an order ;)
Have a nice day!