Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix index not being served for precompressed assets #205

Merged
merged 6 commits into from May 18, 2021
Merged

fix index not being served for precompressed assets #205

merged 6 commits into from May 18, 2021

Conversation

dwickern
Copy link
Contributor

Related to #158

When using the preCompressed option, GET / should look for index.html.br or index.html.gz. Also support the custom index option.

This PR more or less replicates what send does internally.

Checklist

mcollina
mcollina approved these changes May 17, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

Can you please fix the code coverage?

@mcollina mcollina merged commit c65ad91 into fastify:master May 18, 2021
@dwickern dwickern deleted the precompress-index branch May 18, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dwickern @mcollina