Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle @fastify/x names to export #190

Merged
merged 3 commits into from Aug 6, 2022
Merged

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 4, 2022

Checklist

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this solving?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 4, 2022

Before we had e.g. fastify-kafka as module name which was automatically changed to the named export fastifyKafka So it was basically generating module.exports.fastifyKafka = plugin

We renamed all fastify own modules to the form @fastify/x-y-z. So now the named exports are '@fastify/xYZ' which is equivalent to module.exports['@fastify/xYZ'] = plugin.

If the current behaviour is correct, than we have to rewrite the failing test in fastify/fastify-kafka#69 accordingly. If not, we have to merge this, and then the test in that PR will pass.

Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

test/bundlers.test.js Outdated Show resolved Hide resolved
Uzlopak and others added 2 commits August 4, 2022 16:38
Co-authored-by: Vincent Le Goff <vince.legoff@gmail.com>
@Uzlopak Uzlopak requested a review from zekth August 4, 2022 14:44
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 6, 2022

@zekth you want to review again?
@jsumners do you have further questions?

@Eomm Eomm merged commit 36e9271 into fastify:master Aug 6, 2022
@Uzlopak Uzlopak deleted the named-exports branch August 6, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

named exports are not right after renaming the modules
6 participants