Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: manage big file uploads #389

Merged
merged 1 commit into from Sep 4, 2022
Merged

fix: manage big file uploads #389

merged 1 commit into from Sep 4, 2022

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Sep 4, 2022

closes #383

increase coverage #202:

----------|---------|----------|---------|---------|-------------------
File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
----------|---------|----------|---------|---------|-------------------
All files |     100 |    96.85 |     100 |     100 |                   
 index.js |     100 |    96.85 |     100 |     100 | 163,247-254,551   
----------|---------|----------|---------|---------|-------------------

benefit #378:
from https://nodejs.org/api/stream.html#readablesymbolasynciterator

If the loop terminates with a break, return, or a throw, the stream will be destroyed

@Uzlopak Uzlopak merged commit 8245fce into master Sep 4, 2022
@Uzlopak Uzlopak deleted the big-upload branch September 4, 2022 09:01
Uzlopak pushed a commit that referenced this pull request Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RequestFileTooLargeError is not raised with streams even though fileSize limit is set
2 participants