Skip to content

test: test for array and regex origin options (#77) #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2020
Merged

test: test for array and regex origin options (#77) #81

merged 1 commit into from
Aug 5, 2020
+68 −1

Conversation

alemagio
Copy link
Contributor

@alemagio alemagio commented Aug 5, 2020

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

Sorry, something went wrong.

mcollina
mcollina approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

mcollina commented Aug 5, 2020

Can you please add the --100 flag to tap to verify it's 100% in Ci?

@alemagio
Copy link
Contributor Author

alemagio commented Aug 5, 2020

Sure

@alemagio
Copy link
Contributor Author

alemagio commented Aug 5, 2020

My bad actually, we have all line covered but not all branches.
If you don't mind I'll fix it asap.

@mcollina
Copy link
Member

mcollina commented Aug 5, 2020

Landing this then

@mcollina mcollina merged commit 129e98f into fastify:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alemagio @mcollina