Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return Serializer instance in debug mode #529

Merged
merged 1 commit into from Sep 9, 2022
Merged

fix: return Serializer instance in debug mode #529

merged 1 commit into from Sep 9, 2022

Conversation

ivan-tymoshenko
Copy link
Member

@ivan-tymoshenko ivan-tymoshenko commented Sep 8, 2022 •
edited

Checklist

mcollina
mcollina requested changes Sep 8, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a breaking change?

@ivan-tymoshenko
Copy link
Member Author

is this a breaking change?

No, it's a bug fix.

mcollina
mcollina approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 26ef3cd into master Sep 9, 2022
@Uzlopak Uzlopak deleted the return-serializer-instance-in-debug-mode branch September 9, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@climba03003 climba03003 climba03003 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivan-tymoshenko @mcollina @climba03003