New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: handle nullable schema in one place #523

Merged

Eomm merged 1 commit into master from handle-nullable-schema-in-one-place

Sep 5, 2022

Member

ivan-tymoshenko commented Sep 5, 2022

I'm sorry that there are so many changes. Most of them are decomposition into functions without changes. This PR does two things:

Handles nullable property in one place instead of checking it all over the code.
Optimize handling multitype schemas.

I can't separate these two changes. They are related to each other.


          refactor: handle nullable schema in one place

163eaef

mcollina approved these changes

View reviewed changes

Member

mcollina left a comment

lgtm

Eomm approved these changes

View reviewed changes

Eomm merged commit 8f4fdfc into master

Eomm deleted the handle-nullable-schema-in-one-place branch

September 5, 2022 20:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment