Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for issue #246 #500

Merged
merged 1 commit into from Aug 2, 2022
Merged

test: add test for issue #246 #500

merged 1 commit into from Aug 2, 2022

Conversation

ivan-tymoshenko
Copy link
Member

@ivan-tymoshenko ivan-tymoshenko commented Aug 2, 2022 •
edited

Checklist

Close #246

#246 was fixed in one of the refactoring PR. This PR adds a test case from the issue.

mcollina
mcollina approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit d14112b into master Aug 2, 2022
@Uzlopak Uzlopak deleted the add-test-for-issue-246 branch August 3, 2022 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OneOf between arrays of object with nullable fields that are null breaks the serialization
2 participants
@ivan-tymoshenko @mcollina